forked from rust-lang/rustlings
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from rust-lang:main #225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use gitattributes file to ensure script files have LF line endings. This solves a problem for users who wish to use DevContainers on Windows machines and the file has been cloned from the repository with CRLF line endings.
The install.sh script didn't work for me, after I changed this locally it worked URL needs to end in .git
I struggled with this exercise and didn't understand that it was looking for a summary of goals scored/conceded per team, instead of per match. My goal here is just to clarify the language, essentially saying "the total number of goals the team scored" to indicate that we are looking for a sum. Updated the exercise description to clarify this point. Relates loosely to closed issue #1361
…cription Update hashmaps3.rs description for clarity
Bumps [mio](https://github.com/tokio-rs/mio) from 0.8.9 to 0.8.11. - [Release notes](https://github.com/tokio-rs/mio/releases) - [Changelog](https://github.com/tokio-rs/mio/blob/master/CHANGELOG.md) - [Commits](tokio-rs/mio@v0.8.9...v0.8.11) --- updated-dependencies: - dependency-name: mio dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Instead of running `rustup` on a multi-gigabyte general-purpose Linux base, use the premade devcontainers/rust:1 which closely tracks the rust toolchain releases. Rip out excess setup steps since devcontainers come with the repo checked out; just compile/update the binary.
Makes the pre-built command work in the shell right away.
It's already in the vendor-specific .vscode files.
Signed-off-by: pavedroad <qcqs@outlook.com>
…onim2245 docs: add AnonimAnonim2245 as a contributor for code
chore: update from_into.rs task description to fit the code
…th-dev docs: add reifenrath-dev as a contributor for content
fix: Ensure scripts have LF line endings
Clarify language in hashmap3.rs (sum vs per match)
…er2112 docs: add evanmiller2112 as a contributor for content
Fix(Installation) Added .git to end of Repo's https URL
…hill docs: add luvchurchill as a contributor for code
chore: fixed minor typo
docs: add LeverImmy as a contributor for content
Cleaned Up Unused Mutability
docs: add parnavh as a contributor for content
chore: fix a minor typo
docs: add 0Ahmed-0 as a contributor for content
Update dependencies
Co-authored-by: liv <shadows@with.al>
docs: Added comment for handling equal numbers in if/if1.rs `bigger` function
docs: add guizo792 as a contributor for content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )