Avoid usage of deprecated tmpnam function #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linker advises not to use tmpnam: "<artificial>:(.text+0x2761): warning: the use of `tmpnam' is dangerous, better use `mkstemp' " Introduce function to get tmp file path based on current time. I.e we went from: "/tmp/filecQmvY8.pcap" to "/tmp/file1712574386700751477.pcap"
| void tAutotest::recvThread(std::string interfaceName, | ||
| std::vector<std::string> expectFilePaths) | ||
| { | ||
| PcapDumper pcapDumper(std::tmpnam(nullptr) + std::string(".pcap")); | ||
| PcapDumper pcapDumper(generate_temp_filepath() + ".pcap"); |
There was a problem hiding this comment.
I would prefer to use mkstemp here because we may to run test in parallel and the code above is not concurrent safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linker advises not to use tmpnam:
yanet-builder meson compile -C build_autotestshows":(.text+0x2761): warning: the use of
tmpnamis dangerous, better usemkstemp"Introduce function to get tmp file path based on current time.
I.e we went from: "/tmp/filecQmvY8.pcap" to "/tmp/file1712574386700751477.pcap"