Fixes updated slow worker mixing up packets between interfaces #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRandomCharacter
force-pushed
the
slowfix
branch
from
ada7a85
to
bbb06b6
Compare
ol-imorozko
requested changes
Oct 7, 2024
dataplane/dataplane.cpp
Outdated
Comment on lines
1152
to
1177
| const auto name = std::get<0>(config.ports.at(iface.data())).c_str(); | ||
| if (rte_eth_dev_get_port_by_name(name, &port)) |
There was a problem hiding this comment.
Mb add a method analogous to std::string InterfaceNameFromPort(tPortId id) { return std::get<0>(ports[id]); }; from cDataPlane class, this looks very similar
Comment on lines
+32
to
+49
|
|
||
| PortMapper(const PortMapper& other) | ||
| { | ||
| *this = other; | ||
| } | ||
|
|
||
| PortMapper& operator=(const PortMapper& other) | ||
| { | ||
| ports_count_ = other.ports_count_; | ||
| std::copy(std::begin(other.dpdk_ports_), | ||
| std::end(other.dpdk_ports_), | ||
| std::begin(dpdk_ports_)); | ||
| std::copy(std::begin(other.logical_ports_), | ||
| std::end(other.logical_ports_), | ||
| std::begin(logical_ports_)); | ||
| return *this; | ||
| } | ||
|
|
There was a problem hiding this comment.
We should just use std::array instead of c-style arrays.
std::array<tPortId, std::numeric_limits<tPortId>::max() + 1> dpdk_ports_{INVALID_PORT_ID};
std::array<tPortId, std::numeric_limits<tPortId>::max() + 1> logical_ports_{INVALID_PORT_ID};std::array has default = operator, your code will become
PortMapper(const PortMapper& other) = default;
PortMapper& operator=(const PortMapper& other) = default;Plus the default constructor could be implemented with .fill method:
PortMapper()
{
dpdk_ports_.fill(INVALID_PORT_ID);
logical_ports_.fill(INVALID_PORT_ID);
}
TheRandomCharacter
force-pushed
the
slowfix
branch
from
9ed6a59
to
af3c971
Compare
ol-imorozko
reviewed
Oct 8, 2024
Comment on lines
+8
to
+9
| char cname[256]; | ||
| if (int res = rte_eth_dev_get_name_by_port(pid, cname); res) |
There was a problem hiding this comment.
Suggested change
| char cname[256]; | |
| if (int res = rte_eth_dev_get_name_by_port(pid, cname); res) | |
| std::array<char, 256> cname; | |
| if (int res = rte_eth_dev_get_name_by_port(pid, cname.data()); res) |
Wow, found new github feature, didn't know about that
TheRandomCharacter
force-pushed
the
slowfix
branch
from
6d03837
to
518e396
Compare
for each controlplane worker one needs to provide only the core used for
the worker and list of fast worker cores serviced.
"controlPlaneWorkers": [
{
"core": 42,
"serviced_cores": [4, 2]
}
]
TheRandomCharacter
force-pushed
the
slowfix
branch
from
518e396
to
831f80e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.