Perf analysis based on tsc delta measurements #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatancuyu
force-pushed
the
main
branch
7 times, most recently
from
dbdf8b9
to
0e7c4a0
Compare
yatancuyu
force-pushed
the
main
branch
4 times, most recently
from
f9ce230
to
e002438
Compare
yatancuyu
commented
Jan 19, 2024
cli/show.h
Outdated
| dataplane.updateGlobalBase(globalbase); | ||
| } | ||
|
|
||
| static const std::map<std::string, unsigned int> counter_name_to_offset = { |
There was a problem hiding this comment.
Should i use array instead of struct for dataplane::perf::tsc_base_values, to avoid this?
yatancuyu
commented
Jan 19, 2024
| common::idp::updateGlobalBase::request globalbase; | ||
| globalbase.emplace_back(common::idp::updateGlobalBase::requestType::tscs_base_value_update, | ||
| common::idp::updateGlobalBase::tscs_base_value_update::request{counter_name_to_offset.at(counter_name), value}); | ||
| dataplane.updateGlobalBase(globalbase); |
There was a problem hiding this comment.
Is it ok to update GlobalBase from cli?
taitov
reviewed
Jan 29, 2024
| @@ -105,6 +109,7 @@ std::vector<std::tuple<std::string, | |||
| {"dontdoit podumoi controlplane rib save", "", [](const auto& args) { call(rib::save, args); }}, | |||
| {"dontdoit podumoi controlplane rib load", "", [](const auto& args) { call(rib::load, args); }}, | |||
| {"dontdoit podumoi controlplane rib clear", "[protocol] <peer> <vrf> <priority>", [](const auto& args) { call(rib::clear, args); }}, | |||
| {"dontdoit podumoi tsc monitoring", "", [](const auto& args) { call(develop::dataplane::tsc_monitoring, args); }}, | |||
There was a problem hiding this comment.
Maybe move to just "tsc monitoring" =)
taitov
previously approved these changes
Jan 29, 2024
yatancuyu
force-pushed
the
main
branch
2 times, most recently
from
b8199b3
to
81267bc
Compare
|
Squash and rebase to main, please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#74