Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Toggle language indicator' #383

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

HUMORCE
Copy link

@HUMORCE HUMORCE commented Sep 30, 2024

@yannbertrand
Copy link
Owner

yannbertrand commented Dec 19, 2024

Hi there, thanks for the PR.

I've just published a contribution guide, please take a look at it.

Especially:

  • Review titles and description,
  • Add some context infos,
  • Add a requirements section,
  • Add some screenshots if possible.

Let me know if something is not clear!

@HUMORCE
Copy link
Author

HUMORCE commented Dec 21, 2024

Okay, I'll add them later.

@yannbertrand
Copy link
Owner

Let me know if something is missing/not clear :)

@HUMORCE HUMORCE changed the title Add 'Disable language indicator' Add 'Toggle language indicator' Jan 3, 2025
@HUMORCE
Copy link
Author

HUMORCE commented Jan 3, 2025

Review titles and description,

Done

Add some context infos,

I'm not sure what's missing.

Add a requirements section,

No additional requirements.

Add some screenshots if possible.

Done

@yannbertrand
Copy link
Owner

You can move the command to the keyboard folder :)

HUMORCE and others added 8 commits January 7, 2025 05:14
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
@yannbertrand
Copy link
Owner

Images should be moved inside an images folder

HUMORCE and others added 5 commits January 7, 2025 05:19
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
Co-authored-by: Yann Bertrand <5855339+yannbertrand@users.noreply.github.com>
@HUMORCE
Copy link
Author

HUMORCE commented Jan 6, 2025

I was created an empty commit while switching branch before, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants