Fix results label in simulation #1929
Open
+83
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #1927 --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/yaptide/ui/issues/1927?shareId=XXXX-XXXX-XXXX-XXXX).
…r` and its `outputs` field * Add console logs for `inputJsonForThisEstimator` and its `outputs` field
…ts` field * **Recreate references functions** - Document `recreateRefsInResults`, `recreateRefToFilters`, and `recreateRefToScoringManagerOutputs` functions * **Error message** - Fix typo in error message from "esitamtors" to "estimators" * **Input JSON handling** - Make a copy of `jobInputs.input.inputJson` and assign it to `inputJsonForThisEstimator` - Ensure `inputJsonForThisEstimator` contains a field called `outputs` - Pass a single-element list as `outputs` to `recreateRefsInResults` - Dump `inputJsonForThisEstimator` to the console, particularly its `outputs` field
…ass filtered outputs * Make a copy of `jobInputs.input.inputJson` and assign it to `inputJsonForThisEstimator` * Ensure `inputJsonForThisEstimator` contains a field called `outputs` * Pass a single-element list as `outputs` to `recreateRefsInResults` * Update `data` object and `resolve` logic to handle the new `inputJsonForThisEstimator`
…gging * Make a copy of `jobInputs.input.inputJson` and assign it to `inputJsonForThisEstimator` * Ensure `inputJsonForThisEstimator` contains a field called `outputs` * Pass a single-element list as `outputs` to `recreateRefsInResults` * Add logging for `inputJsonForThisEstimator` in the console * Add debugging logging to console in `recreateRefToScoringManagerOutputs`, `recreateRefToFilters`, and `recreateRefsInResults` * Add comments explaining code logic in `recreateRefToScoringManagerOutputs`, `recreateRefToFilters`, and `recreateRefsInResults`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
src/services/ShSimulatorService.tsxfile to improve the handling of references between estimators and their corresponding outputs and filters. The most important changes include the addition of new functions to rebuild these references and enhancements to error handling and logging.Enhancements to reference handling:
recreateRefToScoringManagerOutputsto rebuild references between estimators and their corresponding scoring manager outputs.recreateRefToFiltersfunction to rebuild references between estimators, their pages, and filters by linking filter UUIDs with actual filter objects.recreateRefsInResultsfunction to include detailed error handling and logging when input JSON or estimators are undefined.Improvements to
ShSimulationcomponent:ShSimulationcomponent to conditionally recreate references in results based on the availability of editor project data, ensuring proper handling of user-uploaded files. [1] [2]Related to Results gets wrong label #1927
For more details, open the Copilot Workspace session.