Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wsl systemd #150

Merged
merged 7 commits into from
Dec 21, 2023
Merged

Wsl systemd #150

merged 7 commits into from
Dec 21, 2023

Conversation

jreidinger
Copy link
Member

@jreidinger jreidinger commented Dec 14, 2023

Problem

WSL now supports systemd when some tuning is done. And that tuning is packaged as pattern with bunch of deps.

jira: https://jira.suse.com/browse/PED-5099

Solution

Implement checkbox as requested and also adapt a bit help text as mentioned in that jira entry.

Testing

  • Added a new unit test
  • Manually tested and documented how to test it.

Screenshot

wsl_firstboot

wsl_firstboot_help

wsl_gui_pattern))
wsl_gui_pattern)),
# TRANSLATORS:
Label(_("The WSL systemd pattern provides wsl.conf adjustment and init symlink for\n" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkbox label is IMHO too technical, that should be part of the documentation and in the help text.

For label I'd prefer some simpler, less technical description understandable for more users.

Something like "The WSL systemd pattern allows using the Linux services inside a WSL container."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is kind of similar to the one about WSL GUI. I am fine with simplifying both, but I am not sure about who is target user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @lslezak. I would something like he proposed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, goal of the PBI is to use similar wording like in pattern description and I also ask on discuss-wsl on slack for feedback. To be honest I am not sure about terms used in WSL like if we should talk about services or container in WSL context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, well, we can change it if somebody complains.


### Creating Testing APPX

The easiest way for me is to use OBS. Find the target release for WSL image like `SUSE:SLE-15-SP6:Update:WSL`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would about "for me" in this documents. Instead, I would directly say "The easiest way is to use OBS".

modified sources with rake tarball. It is also mandatory to link or branch package `wsl-appx` as it ensures
that certificate used for appx matches with the one used in kiwi.
Another important think is to ensure that certificate for home repo is valid and not outdated. To check it use
`osc signkey --sslcert home:...` and if it is invalid use `osc signkey --sslcert --create home:jreidinger`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/home:jreidinger/<obs-home-project-name>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will use similar like in previous command that home:... to be consistent


### Installing Modified APPX

Just follow instructions on https://en.opensuse.org/WSL/Manual_Installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: on or at?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I plan to use "on page" and ends in the middle.

### Installing Modified APPX

Just follow instructions on https://en.opensuse.org/WSL/Manual_Installation
If there are any issue appx installer gets quite useless error, so use help at https://en.opensuse.org/WSL/Debugging_Hints
Copy link
Contributor

@joseivanlopez joseivanlopez Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: I would change the sentence: appx installer reports quite useless error when there is any issue, so ...

-------------------------------------------------------------------
Thu Dec 14 20:38:43 UTC 2023 - Josef Reidinger <jreidinger@suse.com>

- Allow selection WSL systemd pattern (jsc#PED-5644, jsc#PED-5099)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: Allow selecting WSL ...

_("<p>For enablement of systemd in WSL the WSL systemd pattern provides wsl.conf " \
"and /sbin/init adjustments. " \
"In that case the system needs to be registered as well. " \
"Also be aware that systemd enablement is in effect only after relaunch.</p>")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reword the last sentence a bit: "Reboot is required for enabling systemd".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem is that in wsl it is not reboot. That is why I use relaunch...so I would use your sentence with Relaunch

@jreidinger jreidinger merged commit 7e3829b into SLE-15-SP6 Dec 21, 2023
12 checks passed
@jreidinger jreidinger deleted the wsl_systemd branch December 21, 2023 08:25
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #2 successfully finished
✔️ Created IBS submit request #316161

@jreidinger jreidinger mentioned this pull request Dec 21, 2023
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #3 successfully finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants