Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case-insensitive finding of LICENSE.*.TXT (bsc#1215698) #1292

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Fix case-insensitive finding of LICENSE.*.TXT (bsc#1215698) #1292

merged 3 commits into from
Oct 6, 2023

Conversation

mvidner
Copy link
Member

@mvidner mvidner commented Oct 3, 2023 •
edited
Loading

Problem

"License Agreement" not shown in installer (maybe related to KVM??)

it turns out Ruby 3.1 drops the formerly working FNM_CASEFOLD for Dir.glob but it keeps working for File.fnmatch?

Solution

Implement a globbing method that avoids the dropped feature

Testing

  • Extended an existing test, checked that it fails/succeeds before/after fix

Screenshots

N/A

@mvidner
Copy link
Member Author

mvidner commented Oct 4, 2023

ah, I need to add FNM_EXTGLOB for brace expansion,
and add a casematching filename to the test data

@mvidner
Rename a .TXT file to .txt to test the casematching code
1c79a8b 
usr/etc/YaST2/licenses/licenses_test_package/LICENSE.cz_CZ.TXT
to
usr/etc/YaST2/licenses/licenses_test_package/LICENSE.cz_CZ.txt
@mvidner
Fix case-insensitive finding of LICENSE.*.TXT (bsc#1215698)
53eeac8 
Ruby 3.1 drops the formerly working FNM_CASEFOLD for `Dir.glob`
but it keeps working for `File.fnmatch?`

For added fun, `glob` has brace expansion built in but `fnmatch?` needs
`FNM_EXTGLOB` for that.
@coveralls
Copy link

coveralls commented Oct 4, 2023 •
edited
Loading

Coverage Status

coverage: 41.872% (+0.008%) from 41.864% when pulling e3b678e on broken-casefold into c443e4d on master.

@mvidner
Copy link
Member Author

mvidner commented Oct 4, 2023

ah, version+changelog missing

@mvidner mvidner marked this pull request as ready for review October 5, 2023 08:51
@mvidner mvidner merged commit e5c76d7 into master Oct 6, 2023
16 checks passed
@mvidner mvidner deleted the broken-casefold branch October 6, 2023 08:15
@mvidner
Copy link
Member Author

mvidner commented Oct 6, 2023 •
edited
Loading

OBS SR: https://build.opensuse.org/request/show/1115986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseivanlopez joseivanlopez joseivanlopez approved these changes

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvidner @coveralls @joseivanlopez @dgdavid