fix delete session #2591
fix delete session #2591
Conversation
yegorskii
added
large-tests
| @@ -12,7 +12,7 @@ namespace { | |||
|
|
|||
| constexpr size_t MaxSubSessions = 2; | |||
|
|
|||
| } | |||
| } // namespace | |||
There was a problem hiding this comment.
отступ перед // namespace у нас обычно другой
| return owner; | ||
| } | ||
|
|
||
| // update sequence number fir ro and rw clients |
| SubSessions, | ||
| [&] (const auto& subsession) { | ||
| return subsession.Owner == owner; | ||
| }); | ||
| if (subsession == SubSessions.end()) { | ||
| return true; | ||
| return MaxRoSeqNo != 0 || MaxRwSeqNo != 0; |
| return false; | ||
| } | ||
| // check if writer is deleted | ||
| bool writerAlive = subsession->SeqNo < MaxRwSeqNo; |
There was a problem hiding this comment.
а почему так проверяем? мы тут разве считаем, что subsession - это точно writer?
|
|
||
| return true; | ||
| return SubSessions.size() || writerAlive || migrationInProgress; |
There was a problem hiding this comment.
разве из того факта, что writer у нас alive, не следует автоматически, что SubSessions непуст? то есть разве условие SubSessions.size() || writerAlive не эквивалентно просто условию SubSessions.size()?
| } | ||
|
|
||
| SubSessions.erase(subsession); | ||
| // check if writer is deleted |
| void TSubSessions::UpdateSeqNoAfterDelete(ui64 seqNo) | ||
| { | ||
| if (seqNo == MaxRoSeqNo) { | ||
| MaxRoSeqNo = 0; |
There was a problem hiding this comment.
а другие сессии нам тут разве неинтересны? почему Max*SeqNo сбрасываются в 0, а не в max по остальным subsessions?
| ui32 DeleteSubSession(ui64 sessionSeqNo); | ||
| bool DeleteSubSession(const NActors::TActorId& owner); | ||
| bool DeleteSubSession(ui64 sessionSeqNo); | ||
| void UpdateSeqNoAfterDelete(ui64 seqNo); |
There was a problem hiding this comment.
это разве должно быть публичным методом?
| ui32 nodeIdx = env.CreateNode("nfs"); | ||
| ui64 tabletId = env.BootIndexTablet(nodeIdx); | ||
|
|
||
| { |
There was a problem hiding this comment.
без комментариев непонятно, что зачем делается - почему именно такой порядок событий
#2590
The problem was that after tablet restart it does not have connected client records but only sequence numbers for rw and ro clients. But it turned out that instead of reconnecting with CreateSession, client can send just DestroySession. And this situation was not handled properly.