[Disk Manager] add ability to run multiple disk agents in disk manager large tests #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disk registry state backup after the service initialization is the following. Looks good. |
SvartMetal
reviewed
Dec 9, 2024
cloud/disk_manager/internal/pkg/facade/snapshot_service_nemesis_test/ya.make
Outdated
Show resolved
Hide resolved
komarevtsev-d
approved these changes
Dec 9, 2024
SvartMetal
approved these changes
Dec 9, 2024
gy2411
deleted the
users/gayurgin/add_ability_to_run_multiple_da_in_dm_large_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1950
Add
--disk-agents-countparameter to the receipt of dm large tests. This parameter is 1 by default, and we set it to 3 for snapshot service tests (since we are going to add there a test for #1950, and this test requires multiple disk agents).Now the receipt runs disk agents similarly to https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/tests/client/test_with_multiple_agents.py
Needed for testing of #1950 (and any other large tests with shadow disks). Also will be useful if we want to create mirror3 disks in dm large tests.