Issue 2709: add cleanup of leaked devices #2745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for contributing! |
vladstepanyuk
commented
Dec 20, 2024
cloud/blockstore/libs/storage/disk_registry/model/device_list.h
Outdated
Show resolved
Hide resolved
vladstepanyuk
commented
Dec 20, 2024
cloud/blockstore/libs/storage/disk_registry/model/device_list.cpp
Outdated
Show resolved
Hide resolved
komarevtsev-d
added
ok-to-test
github-actions
bot
removed
the
ok-to-test
drbasic
requested changes
Dec 23, 2024
cloud/blockstore/libs/storage/disk_registry/testlib/test_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
ok-to-test
vladstepanyuk
force-pushed
the
issue-2709
branch
from
107d852 to
f23a59d
Compare
drbasic
reviewed
Dec 23, 2024
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
drbasic
reviewed
Dec 23, 2024
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.h
Outdated
Show resolved
Hide resolved
drbasic
requested changes
Dec 23, 2024
.../blockstore/libs/storage/disk_registry/disk_registry_actor_cleanup_devices_without_agent.cpp
Outdated
Show resolved
Hide resolved
sharpeye
reviewed
Dec 23, 2024
.../blockstore/libs/storage/disk_registry/disk_registry_actor_cleanup_devices_without_agent.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/model/device_list.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_loadstate.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/testlib/test_state.cpp
Outdated
Show resolved
Hide resolved
drbasic
reviewed
Dec 24, 2024
drbasic
previously approved these changes
Dec 24, 2024
github-actions
bot
removed
the
ok-to-test
sharpeye
reviewed
Dec 24, 2024
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_loadstate.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/testlib/test_state.cpp
Outdated
Show resolved
Hide resolved
sharpeye
reviewed
Dec 25, 2024
cloud/blockstore/libs/storage/disk_registry/disk_registry_state_ut.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/testlib/test_state.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_cleanup_orphan_devices.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_cleanup_orphan_devices.cpp
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
ok-to-test
drbasic
previously approved these changes
Dec 27, 2024
github-actions
bot
removed
the
ok-to-test
sharpeye
reviewed
Dec 27, 2024
| // CleanupOrphanDevices | ||
| // | ||
|
|
||
| struct TCleanupOrphanDevices |
There was a problem hiding this comment.
У нас есть транзакция TCleanupDevices , которая чистит девайсы. А TCleanupOrphanDevices удаляет девайсы. Давай переименуем в TRemoveOrphanDevices.
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2709