issue-1146: allow other operations to complete during noderefs loading #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debnatkh
added
large-tests
WilyTiger
previously approved these changes
Jan 7, 2025
SvartMetal
reviewed
Jan 7, 2025
cloud/filestore/libs/storage/tablet/tablet_actor_loadstate_noderefs.cpp
Outdated
Show resolved
Hide resolved
SvartMetal
previously approved these changes
Jan 7, 2025
SvartMetal
approved these changes
Jan 7, 2025
yegorskii
approved these changes
Jan 9, 2025
debnatkh
deleted the
users/debnatkh/issue-1146-fix-freezes-upon-noderefs-loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1146
Fixes after #2241
Earlier LoadNodeRefs executed transaction that upon completion immediately executed transaction for the next batch. In this approach there were no gaps allowing for a concurrent operation to complete. In this PR this issue is resolved by sending messages to trigger another batch loading