Skip to content

Commit

Permalink
fix linter
Browse files Browse the repository at this point in the history
  • Loading branch information
KirillKurdyukov committed Oct 28, 2024
1 parent e1c5b55 commit d5d5e02
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 17 deletions.
7 changes: 3 additions & 4 deletions src/Ydb.Sdk/src/Services/Topic/Reader/Reader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ namespace Ydb.Sdk.Services.Topic.Reader;

internal class Reader<TValue> : IReader<TValue>
{
internal Reader(Driver driver, ReaderConfig config, IDeserializer<TValue> deserializer)
{
throw new NotImplementedException();
}
// internal Reader(Driver driver, ReaderConfig config, IDeserializer<TValue> deserializer)
// {
// }

internal Task Initialize()
{
Expand Down
27 changes: 14 additions & 13 deletions src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,19 @@ public ReaderBuilder(Driver driver, ReaderConfig config)

public async Task<IReader<TValue>> Build()

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / run-examples (latest, 6.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / Inspection (./src/YdbSdk.sln)

"[CSharpWarnings::CS1998] This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread." on /home/runner/work/ydb-dotnet-sdk/ydb-dotnet-sdk/src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs(16,359)

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / integration-tests (trunk, 6.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / run-examples (latest, 7.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / run-examples (24.1, 6.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / integration-tests (trunk, 7.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / run-examples (24.1, 7.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / unit-tests (ubuntu-22.04, 6.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / unit-tests (ubuntu-22.04, 7.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / unit-tests (windows-2022, 6.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / unit-tests (windows-2022, 7.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / unit-tests (macos-12, 6.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 16 in src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

View workflow job for this annotation

GitHub Actions / unit-tests (macos-12, 7.0.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
var reader = new Reader<TValue>(
_driver,
_config,
Deserializer ?? (IDeserializer<TValue>)(
Deserializers.DefaultDeserializers.TryGetValue(typeof(TValue), out var deserializer)
? deserializer
: throw new YdbWriterException("The serializer is not set")
)
);

await reader.Initialize();

return reader;
throw new NotImplementedException();
// var reader = new Reader<TValue>(
// _driver,
// _config,
// Deserializer ?? (IDeserializer<TValue>)(
// Deserializers.DefaultDeserializers.TryGetValue(typeof(TValue), out var deserializer)
// ? deserializer
// : throw new YdbWriterException("The serializer is not set")
// )
// );
//
// await reader.Initialize();
//
// return reader;
}
}

0 comments on commit d5d5e02

Please sign in to comment.