Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init IReader, ReaderConfig, ReaderBuilder #207

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Conversation

KirillKurdyukov
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Oct 28, 2024

🌋 Here are results of SLO test for .NET SDK over table-service:

Grafana Dashboard

SLO-table-service

Copy link

github-actions bot commented Oct 28, 2024

🌋 Here are results of SLO test for ADO.NET over query-service:

Grafana Dashboard

SLO-ado-net

src/Ydb.Sdk/src/Services/Topic/IReader.cs Outdated Show resolved Hide resolved

internal class Reader<TValue> : IReader<TValue>
{
public Reader(Driver driver, ReaderConfig config, IDeserializer<TValue> deserializer)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Reader is created right on the Driver? Not on TopicClient as in other SDKs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReaderBuilder:

        var reader = new Reader<TValue>(
            _driver,
            _config,
            Deserializer ?? (IDeserializer<TValue>)(
                Deserializers.DefaultDeserializers.TryGetValue(typeof(TValue), out var deserializer)
                    ? deserializer
                    : throw new YdbWriterException("The serializer is not set")
            )
        );
        
        await reader.Initialize();
        
        return reader;

src/Ydb.Sdk/src/Services/Topic/Reader/Reader.cs Outdated Show resolved Hide resolved
@KirillKurdyukov KirillKurdyukov enabled auto-merge (squash) October 28, 2024 14:44
@KirillKurdyukov KirillKurdyukov merged commit 676c69e into main Oct 28, 2024
21 checks passed
@KirillKurdyukov KirillKurdyukov deleted the feat-init-reader branch October 28, 2024 14:48
@KirillKurdyukov KirillKurdyukov mentioned this pull request Oct 28, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants