fix(Header): fix developer ui link for embedded UI with proxy #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Nov 5, 2024
| createDeveloperUILinkWithNodeId, | ||
| createPDiskDeveloperUILink, | ||
| createVDiskDeveloperUILink, | ||
| } from '../developerUI'; | ||
|
|
||
| describe('Developer UI links generators', () => { | ||
| describe('createDeveloperUILinkForCurrentHost', () => { |
There was a problem hiding this comment.
Tested function is very simple, tests here are mostly to describe different possible cases (tests as docs) and needed to prevent bugs on functions updates
artemmufazalov
force-pushed
the
1565-developer-ui-link-with-proxy
branch
from
4783a37 to
0eacca4
Compare
Raubzeug
approved these changes
Nov 5, 2024
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1565
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: ✅
Current: 79.20 MB | Main: 79.20 MB
Diff: +0.00 MB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information