feat(Nodes): add grouping #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1411-nodes-grouping
branch
2 times, most recently
from
f789545 to
19e1ff1
Compare
artemmufazalov
force-pushed
the
1411-nodes-grouping
branch
from
19e1ff1 to
23d4212
Compare
Raubzeug
previously approved these changes
Nov 7, 2024
|
|
||
| export function parseNodesGroupByParam( | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| param?: any, |
There was a problem hiding this comment.
Is it possible to set string type?
There was a problem hiding this comment.
It will require to set type to param anyway, because Array.includes requires arg to have the same type as array, although it may accept anything - Type 'string' is not assignable to type 'NodesGroupByField | undefined'
There was a problem hiding this comment.
if Array.some will be used instead of includes, no problems with type will appear
There was a problem hiding this comment.
Array.some doesn't set type to the passed arg. I found workaround with Array.find
Raubzeug
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1411
Stand: https://nda.ya.ru/t/tl439E2b79U5Zq
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: 🔺
Current: 79.23 MB | Main: 79.21 MB
Diff: +0.02 MB (0.02%)
ℹ️ CI Information