Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(QueryEditor): add error highlighting #1833

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(QueryEditor): add error highlighting #1833

wants to merge 3 commits into from
+59 −0

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Jan 16, 2025 •
edited by github-actions bot
Loading

closes #1796
Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
262 257 0 5 0

😟 No changes in tests. 😕

Bundle Size: 🔺

Current: 80.05 MB | Main: 79.96 MB
Diff: +0.08 MB (0.11%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik requested a review from Copilot January 17, 2025 11:43
Copilot
Copilot AI reviewed Jan 17, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
astandrik
astandrik reviewed Jan 17, 2025
View reviewed changes
src/utils/monaco/highlightErrors.ts
disableErrorsHighlighting();

clearTimeout(errorsHighlightingTimeoutId);
errorsHighlightingTimeoutId = setTimeout(() => highlightErrors(), 500);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it highlight incorrect errors if I change editor within 500 ms?

@Raubzeug Raubzeug force-pushed the highlight-errors-1796 branch from 2caf2d8 to 3f22c2f Compare January 17, 2025 12:49
@Raubzeug Raubzeug requested a review from astandrik January 17, 2025 12:49
@Raubzeug Raubzeug requested a review from astandrik January 17, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@artemmufazalov artemmufazalov Awaiting requested review from artemmufazalov

@astandrik astandrik Awaiting requested review from astandrik

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight errors in query text in query editor
2 participants
@Raubzeug @astandrik