Merge pull request #1464 from ydb-platform/pool-leak

* Fixed connections pool leak on failed `ydb.Open` call
ydb-platform · Sep 16, 2024 · 89a10b0 · 89a10b0
2 parents a827ded + a4da503
commit 89a10b0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Fixed connections pool leak on failed `ydb.Open` call
+
 ## v3.80.4
 * Fixed panic on usage metrics package from prometheus adapter on `trace.Driver.OnNewStream` callback
 

diff --git a/driver.go b/driver.go
@@ -274,6 +274,8 @@ func Open(ctx context.Context, dsn string, opts ...Option) (_ *Driver, _ error)
 	}()
 
 	if err = d.connect(ctx); err != nil {
+		_ = d.pool.Release(ctx)
+
 		return nil, xerrors.WithStackTrace(err)
 	}
-Original file line number
+Diff line change
@@ Expand Up @@
     	}()
     	if err = d.connect(ctx); err != nil {
+    		_ = d.pool.Release(ctx)
     		return nil, xerrors.WithStackTrace(err)
     	}
@@ Expand Down @@