use canonized storage path as tier id #12833
Conversation
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
swalrus1
force-pushed
the
canonize-tier-id
branch
from
1af1429 to
5dacc08
Compare
swalrus1
force-pushed
the
canonize-tier-id
branch
from
c45ee42 to
757d88a
Compare
|
⚪ |
|
⚪ |
ydb/core/kqp/ut/olap/tiering_ut.cpp
Outdated
| @@ -68,7 +68,7 @@ class TTestEvictionBase { | |||
| UNIT_ASSERT_GT(columnRawBytes, 0); | |||
| } | |||
|
|
|||
| TestHelper->SetTiering("/Root/olapStore/olapTable", "/Root/tier1", "timestamp"); | |||
| TestHelper->SetTiering("/Root/olapStore/olapTable", "Root/tier1", "timestamp"); | |||
There was a problem hiding this comment.
Хотелось бы тест, который работал проверял работу в двух режима, где ставится "/" и нет.
| @@ -72,7 +73,8 @@ class TTierInfo { | |||
|
|
|||
| TString GetDebugString() const { | |||
| TStringBuilder sb; | |||
| sb << "name=" << Name << ";duration=" << EvictDuration << ";column=" << EvictColumnName << ";serializer="; | |||
| sb << "storage=" << (ExternalStorageId ? ExternalStorageId->GetConfigPath() : "") << ";duration=" << EvictDuration << ";column=" << EvictColumnName | |||
There was a problem hiding this comment.
По старой логике, как я понимаю, писался бы __DELETE, поэтому хотелось бы сохранить предыдущий вывод
| @@ -48,49 +49,53 @@ class TTiersManager: public ITiersManager { | |||
| friend class TTierRef; | |||
| class TTierRefGuard: public TMoveOnly { | |||
| private: | |||
| YDB_READONLY_DEF(TString, TierName); | |||
| NTiers::TExternalStorageId TierId; | |||
There was a problem hiding this comment.
Почему убрал YDB_READONLY_DEF?
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Canonize storage path in CS Tiers
Changelog category
Additional information
Один путь до схемного объекта может описываться строками с разным количеством слешей. Чтобы CS корректно идентифицировал тир по пути в произвольном формате, в качестве id тиров используются канонизированные пути.