Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring FillTopicDescription & FillChangefeedDescription #13077

Merged
merged 17 commits into from
Jan 15, 2025
Merged

Refactoring FillTopicDescription & FillChangefeedDescription #13077

merged 17 commits into from
Jan 15, 2025

Conversation

stanislav-shchetinin
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@stanislav-shchetinin stanislav-shchetinin requested a review from a team as a code owner December 27, 2024 10:26
@stanislav-shchetinin stanislav-shchetinin marked this pull request as draft December 27, 2024 10:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 10:30:49 UTC Pre-commit check linux-x86_64-release-asan for 0b070b8 has started.
⚪ 2024-12-27 10:32:06 UTC Artifacts will be uploaded here
⚪ 2024-12-27 10:35:09 UTC ya make is running...
🔴 2024-12-27 10:38:26 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 10:30:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0b070b8 has started.
⚪ 2024-12-27 10:31:10 UTC Artifacts will be uploaded here
⚪ 2024-12-27 10:34:08 UTC ya make is running...
🔴 2024-12-27 10:37:01 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 10:51:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 82988d6 has started.
⚪ 2024-12-27 10:51:14 UTC Artifacts will be uploaded here
⚪ 2024-12-27 10:54:06 UTC ya make is running...
⚫ 2024-12-27 10:56:38 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 10:51:14 UTC Pre-commit check linux-x86_64-release-asan for 82988d6 has started.
⚪ 2024-12-27 10:51:25 UTC Artifacts will be uploaded here
⚪ 2024-12-27 10:54:16 UTC ya make is running...
⚫ 2024-12-27 10:56:41 UTC Check cancelled

@stanislav-shchetinin stanislav-shchetinin changed the title Refactoring FillTopicDescription Refactoring FillTopicDescription & FillChangefeedDescription Dec 27, 2024
@stanislav-shchetinin stanislav-shchetinin self-assigned this Dec 27, 2024
@stanislav-shchetinin stanislav-shchetinin marked this pull request as ready for review December 27, 2024 10:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 11:00:44 UTC Pre-commit check linux-x86_64-release-asan for d4e1c84 has started.
⚪ 2024-12-27 11:00:56 UTC Artifacts will be uploaded here
⚪ 2024-12-27 11:03:47 UTC ya make is running...
🔴 2024-12-27 11:07:37 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 11:00:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for d4e1c84 has started.
⚪ 2024-12-27 11:01:05 UTC Artifacts will be uploaded here
⚪ 2024-12-27 11:03:58 UTC ya make is running...
🔴 2024-12-27 11:12:12 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 11:57:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0b41f37 has started.
⚪ 2024-12-27 11:57:40 UTC Artifacts will be uploaded here
⚫ 2024-12-27 11:59:22 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 11:57:38 UTC Pre-commit check linux-x86_64-release-asan for 0b41f37 has started.
⚪ 2024-12-27 11:57:49 UTC Artifacts will be uploaded here
⚫ 2024-12-27 11:59:22 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 12:00:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for eaeeacb has started.
⚪ 2024-12-27 12:01:09 UTC Artifacts will be uploaded here
⚪ 2024-12-27 12:04:07 UTC ya make is running...
🟡 2024-12-27 12:50:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19622 18060 0 16 1417 129

⚪ 2024-12-27 12:52:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 13:05:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 77 0 12 0 123

⚪ 2024-12-27 13:05:36 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-27 13:17:19 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
196 (only retried tests) 61 0 12 0 123

🟢 2024-12-27 13:17:31 UTC Build successful.
🟡 2024-12-27 13:17:56 UTC ydbd size 2.1 GiB changed* by +113.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a61cedc merge: eaeeacb diff diff %
ydbd size 2 241 674 192 Bytes 2 241 790 632 Bytes +113.7 KiB +0.005%
ydbd stripped size 471 948 624 Bytes 471 948 368 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 12:01:39 UTC Pre-commit check linux-x86_64-release-asan for eaeeacb has started.
⚪ 2024-12-27 12:01:53 UTC Artifacts will be uploaded here
⚪ 2024-12-27 12:04:51 UTC ya make is running...
🟡 2024-12-27 13:01:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11569 11497 0 38 4 30

⚪ 2024-12-27 13:02:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 13:14:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
126 (only retried tests) 85 0 15 1 25

⚪ 2024-12-27 13:14:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-27 13:25:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78 (only retried tests) 43 0 11 0 24

🟢 2024-12-27 13:25:37 UTC Build successful.
🟡 2024-12-27 13:26:09 UTC ydbd size 3.6 GiB changed* by +149.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a61cedc merge: eaeeacb diff diff %
ydbd size 3 869 477 968 Bytes 3 869 631 416 Bytes +149.9 KiB +0.004%
ydbd stripped size 1 349 128 112 Bytes 1 349 128 816 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL requested changes Dec 27, 2024
View reviewed changes
ydb/core/ydb_convert/topic_description.h Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.h Outdated Show resolved Hide resolved
ydb/core/ydb_convert/table_description.cpp Outdated Show resolved Hide resolved
ydb/core/ydb_convert/table_description.cpp Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.cpp Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.cpp Outdated Show resolved Hide resolved
ydb/services/persqueue_v1/actors/schema_actors.cpp Show resolved Hide resolved
ydb/services/persqueue_v1/actors/schema_actors.cpp Outdated Show resolved Hide resolved
ydb/services/persqueue_v1/actors/schema_actors.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

⚪ 2025-01-10 13:09:40 UTC Pre-commit check linux-x86_64-release-asan for 9cc1a4d has started.
⚪ 2025-01-10 13:09:52 UTC Artifacts will be uploaded here
⚪ 2025-01-10 13:12:53 UTC ya make is running...
🟡 2025-01-10 14:15:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11595 11532 0 27 5 31

⚪ 2025-01-10 14:16:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-10 14:29:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 74 0 3 1 28

⚪ 2025-01-10 14:29:30 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-10 14:41:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 33 0 1 1 26

🟢 2025-01-10 14:41:07 UTC Build successful.
🟡 2025-01-10 14:41:35 UTC ydbd size 3.6 GiB changed* by +152.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f5f4a12 merge: 9cc1a4d diff diff %
ydbd size 3 874 879 552 Bytes 3 875 035 248 Bytes +152.0 KiB +0.004%
ydbd stripped size 1 350 984 496 Bytes 1 350 985 840 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

⚪ 2025-01-10 13:10:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9cc1a4d has started.
⚪ 2025-01-10 13:10:59 UTC Artifacts will be uploaded here
⚪ 2025-01-10 13:14:02 UTC ya make is running...
🟡 2025-01-10 13:59:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18717 17413 0 7 1169 128

⚪ 2025-01-10 14:01:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-10 14:14:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 64 0 6 0 124

⚪ 2025-01-10 14:14:38 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-10 14:29:16 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 55 0 6 0 123

🟢 2025-01-10 14:29:27 UTC Build successful.
🟡 2025-01-10 14:29:49 UTC ydbd size 2.1 GiB changed* by +115.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f5f4a12 merge: 9cc1a4d diff diff %
ydbd size 2 244 922 968 Bytes 2 245 040 856 Bytes +115.1 KiB +0.005%
ydbd stripped size 472 441 872 Bytes 472 441 808 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL reviewed Jan 10, 2025
View reviewed changes
ydb/core/ydb_convert/topic_description.h Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.cpp Outdated Show resolved Hide resolved
ydb/services/persqueue_v1/actors/schema_actors.cpp Outdated Show resolved Hide resolved
ydb/services/persqueue_v1/actors/schema_actors.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

⚪ 2025-01-13 15:27:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6928ea4 has started.
⚪ 2025-01-13 15:27:39 UTC Artifacts will be uploaded here
⚪ 2025-01-13 15:30:33 UTC ya make is running...
🟡 2025-01-13 16:21:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18727 17421 0 10 1169 127

⚪ 2025-01-13 16:23:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-13 16:36:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
195 (only retried tests) 66 0 6 0 123

⚪ 2025-01-13 16:36:13 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-13 16:48:38 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 57 0 6 0 121

🟢 2025-01-13 16:48:44 UTC Build successful.
🟡 2025-01-13 16:49:07 UTC ydbd size 2.1 GiB changed* by +146.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c0dd9da merge: 6928ea4 diff diff %
ydbd size 2 245 790 952 Bytes 2 245 941 328 Bytes +146.9 KiB +0.007%
ydbd stripped size 472 639 696 Bytes 472 641 680 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

⚪ 2025-01-13 15:27:56 UTC Pre-commit check linux-x86_64-release-asan for 6928ea4 has started.
⚪ 2025-01-13 15:28:07 UTC Artifacts will be uploaded here
⚪ 2025-01-13 15:30:56 UTC ya make is running...
🟡 2025-01-13 16:29:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11599 11543 0 22 2 32

⚪ 2025-01-13 16:30:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-13 16:42:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
90 (only retried tests) 62 0 2 1 25

⚪ 2025-01-13 16:42:15 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-13 16:53:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
52 (only retried tests) 25 0 2 0 25

🟢 2025-01-13 16:53:44 UTC Build successful.
🟡 2025-01-13 16:54:13 UTC ydbd size 3.6 GiB changed* by +197.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c0dd9da merge: 6928ea4 diff diff %
ydbd size 3 893 424 088 Bytes 3 893 626 264 Bytes +197.4 KiB +0.005%
ydbd stripped size 1 360 223 984 Bytes 1 360 229 808 Bytes +5.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

⚪ 2025-01-14 13:41:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for b915fb8 has started.
⚪ 2025-01-14 13:42:04 UTC Artifacts will be uploaded here
⚪ 2025-01-14 13:44:56 UTC ya make is running...
🟡 2025-01-14 14:28:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18492 17028 0 176 1162 126

⚪ 2025-01-14 14:30:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-14 14:42:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
343 (only retried tests) 220 0 0 7 116

🟢 2025-01-14 14:42:55 UTC Build successful.
🟡 2025-01-14 14:43:15 UTC ydbd size 2.1 GiB changed* by +144.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f9605fd merge: b915fb8 diff diff %
ydbd size 2 247 484 704 Bytes 2 247 632 480 Bytes +144.3 KiB +0.007%
ydbd stripped size 472 871 728 Bytes 472 872 432 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

⚪ 2025-01-14 13:42:13 UTC Pre-commit check linux-x86_64-release-asan for b915fb8 has started.
⚪ 2025-01-14 13:42:32 UTC Artifacts will be uploaded here
⚪ 2025-01-14 13:45:24 UTC ya make is running...
🟡 2025-01-14 14:41:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11601 11553 0 19 3 26

⚪ 2025-01-14 14:42:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-14 14:54:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
81 (only retried tests) 54 0 1 1 25

⚪ 2025-01-14 14:54:38 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-14 15:07:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47 (only retried tests) 22 0 1 0 24

🟢 2025-01-14 15:07:23 UTC Build successful.
🟡 2025-01-14 15:07:50 UTC ydbd size 3.6 GiB changed* by +199.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: df99e52 merge: b915fb8 diff diff %
ydbd size 3 895 409 352 Bytes 3 895 613 776 Bytes +199.6 KiB +0.005%
ydbd stripped size 1 360 972 048 Bytes 1 360 978 864 Bytes +6.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL requested changes Jan 14, 2025
View reviewed changes
ydb/core/ydb_convert/ya.make Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.h Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.h Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.cpp Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.h Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.cpp Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.cpp Outdated Show resolved Hide resolved
ydb/services/persqueue_v1/actors/schema_actors.cpp Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.cpp Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 08:52:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 067462e has started.
⚪ 2025-01-15 08:52:47 UTC Artifacts will be uploaded here
⚪ 2025-01-15 08:55:38 UTC ya make is running...
🟡 2025-01-15 09:41:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18736 17438 0 2 1174 122

⚪ 2025-01-15 09:43:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 10:01:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
183 (only retried tests) 65 0 0 0 118

🟢 2025-01-15 10:01:35 UTC Build successful.
🟡 2025-01-15 10:01:54 UTC ydbd size 2.1 GiB changed* by +144.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b7192f6 merge: 067462e diff diff %
ydbd size 2 247 465 736 Bytes 2 247 613 416 Bytes +144.2 KiB +0.007%
ydbd stripped size 472 858 544 Bytes 472 863 856 Bytes +5.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 08:55:20 UTC Pre-commit check linux-x86_64-release-asan for 067462e has started.
⚪ 2025-01-15 08:55:34 UTC Artifacts will be uploaded here
⚪ 2025-01-15 08:59:04 UTC ya make is running...
🟡 2025-01-15 10:15:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11606 11428 0 112 36 30

⚪ 2025-01-15 10:16:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 10:30:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
265 (only retried tests) 236 0 3 1 25

⚪ 2025-01-15 10:31:08 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-15 10:43:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51 (only retried tests) 26 0 0 0 25

🟡 2025-01-15 10:43:50 UTC ydbd size 3.6 GiB changed* by +185.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b7192f6 merge: 067462e diff diff %
ydbd size 3 895 388 520 Bytes 3 895 578 176 Bytes +185.2 KiB +0.005%
ydbd stripped size 1 360 960 784 Bytes 1 360 964 656 Bytes +3.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-01-15 10:43:52 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 10:45:23 UTC Pre-commit check linux-x86_64-release-asan for aa8d6a3 has started.
⚪ 2025-01-15 10:45:56 UTC Artifacts will be uploaded here
⚪ 2025-01-15 10:49:18 UTC ya make is running...
⚫ 2025-01-15 10:50:40 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 10:48:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for aa8d6a3 has started.
⚪ 2025-01-15 10:48:15 UTC Artifacts will be uploaded here
⚫ 2025-01-15 10:50:38 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 10:51:30 UTC Pre-commit check linux-x86_64-release-asan for 6e0d4f5 has started.
⚪ 2025-01-15 10:52:39 UTC Artifacts will be uploaded here
⚪ 2025-01-15 10:56:14 UTC ya make is running...
⚫ 2025-01-15 11:08:34 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 10:53:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6e0d4f5 has started.
⚪ 2025-01-15 10:53:28 UTC Artifacts will be uploaded here
⚪ 2025-01-15 10:56:58 UTC ya make is running...
⚫ 2025-01-15 11:08:37 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 11:12:26 UTC Pre-commit check linux-x86_64-release-asan for b33667d has started.
⚪ 2025-01-15 11:12:39 UTC Artifacts will be uploaded here
⚪ 2025-01-15 11:15:38 UTC ya make is running...
🟡 2025-01-15 12:47:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11609 11557 0 20 3 29

⚪ 2025-01-15 12:48:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 13:00:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
85 (only retried tests) 58 0 1 0 26

⚪ 2025-01-15 13:01:02 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-15 13:12:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
49 (only retried tests) 22 0 1 0 26

🟢 2025-01-15 13:12:57 UTC Build successful.
🟡 2025-01-15 13:13:26 UTC ydbd size 3.6 GiB changed* by +176.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ceed259 merge: b33667d diff diff %
ydbd size 3 895 421 736 Bytes 3 895 602 032 Bytes +176.1 KiB +0.005%
ydbd stripped size 1 360 970 864 Bytes 1 360 978 160 Bytes +7.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 11:12:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for b33667d has started.
⚪ 2025-01-15 11:12:33 UTC Artifacts will be uploaded here
⚪ 2025-01-15 11:15:22 UTC ya make is running...
🟡 2025-01-15 12:27:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18739 17447 0 5 1169 118

⚪ 2025-01-15 12:29:51 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 12:41:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 61 0 0 0 117

🟢 2025-01-15 12:41:32 UTC Build successful.
🟡 2025-01-15 12:41:50 UTC ydbd size 2.1 GiB changed* by +130.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ceed259 merge: b33667d diff diff %
ydbd size 2 247 490 904 Bytes 2 247 624 056 Bytes +130.0 KiB +0.006%
ydbd stripped size 472 865 296 Bytes 472 865 872 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL requested changes Jan 15, 2025
View reviewed changes
ydb/core/ydb_convert/topic_description.h Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.h Outdated Show resolved Hide resolved
ydb/core/ydb_convert/topic_description.h Outdated Show resolved Hide resolved
ydb/services/persqueue_v1/actors/schema_actors.cpp Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 14:30:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6e9f0b6 has started.
⚪ 2025-01-15 14:30:52 UTC Artifacts will be uploaded here
⚪ 2025-01-15 14:33:54 UTC ya make is running...
🟡 2025-01-15 15:30:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18761 17459 0 5 1173 124

⚪ 2025-01-15 15:32:14 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 15:48:38 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 72 0 0 0 119

🟢 2025-01-15 15:48:50 UTC Build successful.
🟡 2025-01-15 15:49:11 UTC ydbd size 2.1 GiB changed* by +126.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6bcf4a6 merge: 6e9f0b6 diff diff %
ydbd size 2 251 972 592 Bytes 2 252 101 816 Bytes +126.2 KiB +0.006%
ydbd stripped size 473 567 248 Bytes 473 567 376 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 14:32:52 UTC Pre-commit check linux-x86_64-release-asan for 6e9f0b6 has started.
⚪ 2025-01-15 14:33:08 UTC Artifacts will be uploaded here
⚪ 2025-01-15 14:35:58 UTC ya make is running...
🟡 2025-01-15 15:46:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11615 11559 0 18 9 29

⚪ 2025-01-15 15:47:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 16:00:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 70 0 1 0 24

⚪ 2025-01-15 16:00:44 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-15 16:12:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47 (only retried tests) 23 0 0 0 24

🟢 2025-01-15 16:12:49 UTC Build successful.
🟡 2025-01-15 16:13:16 UTC ydbd size 3.6 GiB changed* by +167.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6bcf4a6 merge: 6e9f0b6 diff diff %
ydbd size 3 903 127 776 Bytes 3 903 299 088 Bytes +167.3 KiB +0.004%
ydbd stripped size 1 362 986 384 Bytes 1 362 988 432 Bytes +2.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@stanislav-shchetinin stanislav-shchetinin merged commit 852697f into ydb-platform:main Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qyryq qyryq qyryq approved these changes

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees

@stanislav-shchetinin stanislav-shchetinin

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stanislav-shchetinin @CyberROFL @qyryq