Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge different schemas #13192

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement
  • Performance improvement

Copy link

github-actions bot commented Jan 7, 2025

2025-01-07 13:20:11 UTC Pre-commit check linux-x86_64-release-asan for da31d41 has started.
2025-01-07 13:20:22 UTC Artifacts will be uploaded here
2025-01-07 13:23:20 UTC ya make is running...
🟡 2025-01-07 14:31:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13270 13213 0 26 4 27

2025-01-07 14:32:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-07 14:44:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 70 0 3 0 25

2025-01-07 14:44:45 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-07 14:56:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
53 (only retried tests) 25 0 3 0 25

🟢 2025-01-07 14:56:13 UTC Build successful.
🟡 2025-01-07 14:56:40 UTC ydbd size 3.6 GiB changed* by +170.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5299845 merge: da31d41 diff diff %
ydbd size 3 873 618 136 Bytes 3 873 793 184 Bytes +170.9 KiB +0.005%
ydbd stripped size 1 350 620 464 Bytes 1 350 672 592 Bytes +50.9 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 7, 2025

2025-01-07 13:20:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for da31d41 has started.
2025-01-07 13:20:31 UTC Artifacts will be uploaded here
2025-01-07 13:23:33 UTC ya make is running...
🟡 2025-01-07 14:30:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27236 24718 0 7 2383 128

2025-01-07 14:32:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-07 14:44:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
196 (only retried tests) 75 0 1 0 120

2025-01-07 14:44:17 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-07 14:55:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 57 0 0 0 119

🟢 2025-01-07 14:55:56 UTC Build successful.
🟡 2025-01-07 14:56:19 UTC ydbd size 2.1 GiB changed* by +105.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5299845 merge: da31d41 diff diff %
ydbd size 2 244 179 536 Bytes 2 244 287 256 Bytes +105.2 KiB +0.005%
ydbd stripped size 472 316 464 Bytes 472 334 640 Bytes +17.8 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review January 7, 2025 15:20
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner January 7, 2025 15:20
Copy link
Collaborator

@zverevgeny zverevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переусложнено. Сотня строчек кода с шаблонами и базовым классом, чтобы реализовать слияние нескольких отсортированных массивов целых чисел

Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 07:08:19 UTC Pre-commit check linux-x86_64-release-asan for b4a169a has started.
2025-01-08 07:08:31 UTC Artifacts will be uploaded here
2025-01-08 07:11:29 UTC ya make is running...
2025-01-08 07:59:37 UTC Check cancelled

Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 07:08:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for b4a169a has started.
2025-01-08 07:08:49 UTC Artifacts will be uploaded here
2025-01-08 07:11:53 UTC ya make is running...
2025-01-08 07:59:39 UTC Check cancelled

Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 08:03:03 UTC Pre-commit check linux-x86_64-release-asan for 88152fb has started.
2025-01-08 08:03:15 UTC Artifacts will be uploaded here
2025-01-08 08:06:15 UTC ya make is running...
🔴 2025-01-08 08:16:49 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 08:03:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 88152fb has started.
2025-01-08 08:03:59 UTC Artifacts will be uploaded here
2025-01-08 08:06:58 UTC ya make is running...
🔴 2025-01-08 08:17:05 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 08:44:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for deeb907 has started.
2025-01-08 08:45:07 UTC Artifacts will be uploaded here
2025-01-08 08:48:06 UTC ya make is running...
🟡 2025-01-08 09:41:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27236 24722 0 2 2383 129

2025-01-08 09:43:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-08 09:55:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 70 0 0 0 124

🟢 2025-01-08 09:55:36 UTC Build successful.
🟡 2025-01-08 09:55:57 UTC ydbd size 2.1 GiB changed* by +105.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 99d530f merge: deeb907 diff diff %
ydbd size 2 244 179 840 Bytes 2 244 287 576 Bytes +105.2 KiB +0.005%
ydbd stripped size 472 316 528 Bytes 472 334 640 Bytes +17.7 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 08:45:08 UTC Pre-commit check linux-x86_64-release-asan for deeb907 has started.
2025-01-08 08:45:21 UTC Artifacts will be uploaded here
2025-01-08 08:48:20 UTC ya make is running...
🟡 2025-01-08 09:47:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13270 13203 0 35 3 29

2025-01-08 09:48:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 10:00:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
112 (only retried tests) 77 0 7 2 26

2025-01-08 10:00:58 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-08 10:12:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 32 0 5 2 25

🟢 2025-01-08 10:12:07 UTC Build successful.
🟡 2025-01-08 10:12:37 UTC ydbd size 3.6 GiB changed* by +171.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 99d530f merge: deeb907 diff diff %
ydbd size 3 873 621 528 Bytes 3 873 796 720 Bytes +171.1 KiB +0.005%
ydbd stripped size 1 350 621 744 Bytes 1 350 673 936 Bytes +51.0 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 force-pushed the merge_different_schemas branch from 57d3dac to ce6e17e Compare January 8, 2025 12:06
Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 12:08:15 UTC Pre-commit check linux-x86_64-release-asan for f485878 has started.
2025-01-08 12:08:31 UTC Artifacts will be uploaded here
2025-01-08 12:11:34 UTC ya make is running...
🟡 2025-01-08 13:13:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13270 13209 0 26 6 29

2025-01-08 13:14:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 13:26:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 67 0 3 3 25

2025-01-08 13:26:55 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-08 13:38:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 27 0 3 1 23

🟢 2025-01-08 13:38:38 UTC Build successful.
🟡 2025-01-08 13:39:05 UTC ydbd size 3.6 GiB changed* by +208.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 99d530f merge: f485878 diff diff %
ydbd size 3 873 621 528 Bytes 3 873 834 608 Bytes +208.1 KiB +0.006%
ydbd stripped size 1 350 621 744 Bytes 1 350 684 176 Bytes +61.0 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 12:08:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for f485878 has started.
2025-01-08 12:08:27 UTC Artifacts will be uploaded here
2025-01-08 12:11:24 UTC ya make is running...
🟡 2025-01-08 13:08:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27236 24718 0 3 2383 132

2025-01-08 13:10:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 13:22:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 73 0 1 0 124

2025-01-08 13:23:04 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-08 13:35:48 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 57 0 1 0 124

🟢 2025-01-08 13:35:55 UTC Build successful.
🟡 2025-01-08 13:36:20 UTC ydbd size 2.1 GiB changed* by +101.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 96abd52 merge: f485878 diff diff %
ydbd size 2 244 213 440 Bytes 2 244 317 080 Bytes +101.2 KiB +0.005%
ydbd stripped size 472 322 416 Bytes 472 336 432 Bytes +13.7 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Jan 8, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 13:55:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for f485878 has started.
2025-01-08 13:56:08 UTC Artifacts will be uploaded here
2025-01-08 13:59:45 UTC ya make is running...
🟡 2025-01-08 14:52:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27236 24689 0 36 2383 128

2025-01-08 14:55:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-08 15:07:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
230 (only retried tests) 107 0 0 0 123

🟢 2025-01-08 15:07:36 UTC Build successful.
🟡 2025-01-08 15:07:57 UTC ydbd size 2.1 GiB changed* by +101.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 96abd52 merge: f485878 diff diff %
ydbd size 2 244 213 440 Bytes 2 244 317 080 Bytes +101.2 KiB +0.005%
ydbd stripped size 472 322 416 Bytes 472 336 432 Bytes +13.7 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 13:56:16 UTC Pre-commit check linux-x86_64-release-asan for f485878 has started.
2025-01-08 13:56:28 UTC Artifacts will be uploaded here
2025-01-08 13:59:29 UTC ya make is running...
🟡 2025-01-08 14:56:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13270 13205 0 28 7 30

2025-01-08 14:57:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 15:09:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
112 (only retried tests) 80 0 5 1 26

2025-01-08 15:09:33 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-08 15:21:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59 (only retried tests) 31 0 2 0 26

🟢 2025-01-08 15:21:14 UTC Build successful.
🟡 2025-01-08 15:21:44 UTC ydbd size 3.6 GiB changed* by +175.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 96abd52 merge: f485878 diff diff %
ydbd size 3 873 655 368 Bytes 3 873 834 608 Bytes +175.0 KiB +0.005%
ydbd stripped size 1 350 627 952 Bytes 1 350 684 176 Bytes +54.9 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 merged commit e7c573f into ydb-platform:main Jan 8, 2025
17 of 18 checks passed
@ivanmorozov333 ivanmorozov333 deleted the merge_different_schemas branch January 8, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants