Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert into nullable PK #13193

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Insert into nullable PK #13193

merged 2 commits into from
Jan 8, 2025
+70 −25

Conversation

zverevgeny
Copy link
Collaborator

Changelog category

  • Not for changelog (changelog entry is not required)

@zverevgeny zverevgeny requested a review from a team as a code owner January 7, 2025 15:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

⚪ 2025-01-07 15:08:17 UTC Pre-commit check linux-x86_64-release-asan for a80ebab has started.
⚪ 2025-01-07 15:08:31 UTC Artifacts will be uploaded here
⚪ 2025-01-07 15:11:29 UTC ya make is running...
🟡 2025-01-07 16:09:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11487 11419 0 31 9 28

⚪ 2025-01-07 16:10:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-07 16:22:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
117 (only retried tests) 80 0 7 6 24

⚪ 2025-01-07 16:22:17 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-07 16:33:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 34 0 4 4 24

🟢 2025-01-07 16:34:00 UTC Build successful.
🟢 2025-01-07 16:34:30 UTC ydbd size 3.6 GiB changed* by -416 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5299845 merge: a80ebab diff diff %
ydbd size 3 873 618 136 Bytes 3 873 617 720 Bytes -416 Bytes -0.000%
ydbd stripped size 1 350 620 464 Bytes 1 350 620 400 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

⚪ 2025-01-07 15:08:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for a80ebab has started.
⚪ 2025-01-07 15:09:06 UTC Artifacts will be uploaded here
⚪ 2025-01-07 15:12:08 UTC ya make is running...
🟡 2025-01-07 16:12:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18403 17104 0 5 1170 124

⚪ 2025-01-07 16:14:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-07 16:25:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 69 0 1 0 120

⚪ 2025-01-07 16:25:40 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-07 16:37:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 56 0 0 0 120

🟢 2025-01-07 16:37:46 UTC Build successful.
🟢 2025-01-07 16:38:08 UTC ydbd size 2.1 GiB changed* by +432 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5299845 merge: a80ebab diff diff %
ydbd size 2 244 179 536 Bytes 2 244 179 968 Bytes +432 Bytes +0.000%
ydbd stripped size 472 316 464 Bytes 472 316 656 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

ivanmorozov333
ivanmorozov333 reviewed Jan 8, 2025
View reviewed changes
ydb/core/kqp/ut/olap/kqp_olap_ut.cpp Outdated
{
const auto resultSelect = client
.ExecuteQuery(
"SELECT * FROM `/Root/ttt`",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавь здесь ORDER BY и проверь сортировку по PK

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавил

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

⚪ 2025-01-08 13:58:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for ae1371f has started.
⚪ 2025-01-08 13:58:58 UTC Artifacts will be uploaded here
⚪ 2025-01-08 14:02:24 UTC ya make is running...
🟡 2025-01-08 14:57:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18403 17102 0 4 1173 124

⚪ 2025-01-08 14:59:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-08 15:10:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 70 0 0 0 120

🟢 2025-01-08 15:10:44 UTC Build successful.
🟢 2025-01-08 15:11:03 UTC ydbd size 2.1 GiB changed* by +368 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 96abd52 merge: ae1371f diff diff %
ydbd size 2 244 213 440 Bytes 2 244 213 808 Bytes +368 Bytes +0.000%
ydbd stripped size 472 322 416 Bytes 472 322 544 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

⚪ 2025-01-08 14:01:27 UTC Pre-commit check linux-x86_64-release-asan for ae1371f has started.
⚪ 2025-01-08 14:01:39 UTC Artifacts will be uploaded here
⚪ 2025-01-08 14:04:28 UTC ya make is running...
🟡 2025-01-08 15:00:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11487 11427 0 25 6 29

⚪ 2025-01-08 15:01:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 15:13:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 65 0 6 1 26

⚪ 2025-01-08 15:14:09 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-08 15:29:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 31 0 5 1 24

🟢 2025-01-08 15:29:08 UTC Build successful.
🟢 2025-01-08 15:29:35 UTC ydbd size 3.6 GiB changed* by -416 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 96abd52 merge: ae1371f diff diff %
ydbd size 3 873 655 368 Bytes 3 873 654 952 Bytes -416 Bytes -0.000%
ydbd stripped size 1 350 627 952 Bytes 1 350 627 888 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny merged commit 9f31130 into ydb-platform:main Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmorozov333 ivanmorozov333 ivanmorozov333 approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zverevgeny @ivanmorozov333