Consider both annotation - current field and parent #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvamelichev
requested changes
Jan 15, 2025
nvamelichev
requested changes
Jan 16, 2025
| @@ -80,4 +80,17 @@ | |||
| */ | |||
| @ExperimentalApi(issue = "https://github.com/ydb-platform/yoj-project/issues/24") | |||
| CustomValueType customValueType() default @CustomValueType(columnClass = Comparable.class, converter = NoConverter.class); | |||
|
|
|||
| enum NamingStrategy { | |||
There was a problem hiding this comment.
There already is a class named NamingStrategy. Let's rename this enum into ColumnNaming or something like that.
nvamelichev
requested changes
Jan 16, 2025
| return (field.getParent() == null) | ||
| ? field.getField().getName() | ||
| : field.getParent().getName() + NAME_DELIMITER + field.getField().getName(); | ||
| if (annotation.namingStrategy() == Column.NamingStrategy.ABSOLUTE) { |
There was a problem hiding this comment.
Using expression switch here will produce clearer code, I think:
var finalColumnName = switch (annotation.columnNaming()) {
case ABSOLUTE –> ...
case RELATIVE -> ...
case LEGACY -> ...
};
return finalColumnName;There was a problem hiding this comment.
Done
Plus extracted method for improving readability
added 2 commits
January 16, 2025 14:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of problem described here: #117