Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

len(AFQDataset.sessions) is not equal to len(AFQDataset.subjects #132

Open
arokem opened this issue Jan 20, 2023 · 2 comments
Open

len(AFQDataset.sessions) is not equal to len(AFQDataset.subjects #132

arokem opened this issue Jan 20, 2023 · 2 comments

Comments

@arokem
Copy link
Collaborator

arokem commented Jan 20, 2023

For datasets with multiple sessions per subject, I would expect that the length of the AFQDataset.sessions would be the same as the length of AFQDataset.subjects and that both of these would be the same as the number of rows in AFQDataset.X. However, currently, this is the way that AFQData.sessions is initialized:

https://github.com/richford/AFQ-Insight/blob/cc6e35cb1e46c76cb91e481bf29da683dffefcb0/afqinsight/datasets.py#L222

which means that it has the length of the original data (in the long format).

@arokem
Copy link
Collaborator Author

arokem commented Jan 20, 2023

This is for the case the default case, where concat_subject_session = False

@arokem
Copy link
Collaborator Author

arokem commented Jan 20, 2023

Maybe we need to do something similar to this with the sessions as well?

https://github.com/richford/AFQ-Insight/blob/cc6e35cb1e46c76cb91e481bf29da683dffefcb0/afqinsight/transform.py#L103-L105

@arokem arokem changed the title len(AFQData.sessions) is not equal to len(AFQData.subjects len(AFQDataset.sessions) is not equal to len(AFQDataset.subjects Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant