Fixed order method #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10530448346Details
💛 - Coveralls |
AnyaWMa
approved these changes
Aug 22, 2024
richford
requested changes
Aug 23, 2024
src/index.ts
Outdated
Comment on lines
307
to
308
| throw new Error('No items left in the array to select.'); | ||
| } |
There was a problem hiding this comment.
Is this the behavior we want? Should we throw an error when the user has exhausted all of the available items? We don't do this in any of the other selector methods. I think if we want to do this, we should do it for all of the methods.
Tagging @AnyaWMa and @Emily-ejag
There was a problem hiding this comment.
I think I added that because it gave me an no-null assertion error.
Do you think changing the next item for this is fine? const nextItem = arr.shift() ?? null;
richford
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method removes and returns the first item in the array, making sure the items are presented in a fixed order.