Skip to content

Commit

Permalink
Merge pull request #515 from yeatmanlab/enh/enable-email
Browse files Browse the repository at this point in the history
Allow email column to be selected in mass uploader
  • Loading branch information
richford authored Apr 19, 2024
2 parents 97ada88 + e715e06 commit 44c894e
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 5 deletions.
4 changes: 3 additions & 1 deletion src/components/CreateAdministration.vue
Original file line number Diff line number Diff line change
Expand Up @@ -271,12 +271,14 @@ const submit = async () => {
const orgsValid = checkForRequiredOrgs(orgs);
if (orgsValid) {
const dateClose = new Date(state.dates[1]);
dateClose.setHours(23, 59, 59, 999);
const args = {
name: toRaw(state).administrationName,
publicName: toRaw(state).administrationPublicName,
assessments: submittedAssessments,
dateOpen: toRaw(state).dates[0],
dateClose: toRaw(state).dates[1],
dateClose,
sequential: toRaw(state).sequential,
orgs: orgs,
isTestData: isTestData.value,
Expand Down
6 changes: 6 additions & 0 deletions src/components/ListUsers.vue
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ const columns = ref([
dataType: 'string',
sort: false,
},
{
field: 'email',
header: 'Email',
dataType: 'string',
sort: false,
},
{
field: 'name.first',
header: 'First Name',
Expand Down
6 changes: 3 additions & 3 deletions src/components/auth/SignIn.vue
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ const isValidEmail = (email) => {
const evaluatingEmail = ref(false);
const allowPassword = ref(true);
const allowLink = ref(false);
const allowLink = ref(true);
const validateRoarEmail = _debounce(
async (email) => {
Expand All @@ -175,7 +175,7 @@ const validateRoarEmail = _debounce(
if (emailAvail) {
console.log(`Email ${email} is available`);
allowPassword.value = false;
allowPassword.value = true;
allowLink.value = false;
} else {
if (roarfirekit.value.isRoarAuthEmail(email)) {
Expand All @@ -184,7 +184,7 @@ const validateRoarEmail = _debounce(
allowPassword.value = true;
} else {
allowLink.value = true;
allowPassword.value = false;
allowPassword.value = true;
state.usePassword = false;
}
}
Expand Down
3 changes: 3 additions & 0 deletions src/pages/ProgressReport.vue
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ const exportSelected = (selectedRows) => {
const computedExportData = _map(selectedRows, ({ user, assignment }) => {
const tableRow = {
Username: _get(user, 'username'),
Email: _get(user, 'email'),
First: _get(user, 'name.first'),
Last: _get(user, 'name.last'),
Grade: _get(user, 'studentData.grade'),
Expand Down Expand Up @@ -518,6 +519,7 @@ const exportAll = async () => {
const computedExportData = _map(exportData, ({ user, assignment }) => {
const tableRow = {
Username: _get(user, 'username'),
Email: _get(user, 'email'),
First: _get(user, 'name.first'),
Last: _get(user, 'name.last'),
Grade: _get(user, 'studentData.grade'),
Expand Down Expand Up @@ -562,6 +564,7 @@ const columns = computed(() => {

const tableColumns = [
{ field: 'user.username', header: 'Username', dataType: 'text', pinned: true, sort: true },
{ field: 'user.email', header: 'Email', dataType: 'text', pinned: false, sort: true },
{ field: 'user.name.first', header: 'First Name', dataType: 'text', sort: true },
{ field: 'user.name.last', header: 'Last Name', dataType: 'text', sort: true },
{ field: 'user.studentData.grade', header: 'Grade', dataType: 'text', sort: true, filter: false },
Expand Down
2 changes: 1 addition & 1 deletion src/pages/RegisterStudents.vue
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ const dropdown_options = ref([
label: 'Required',
items: [
{ label: 'Student Username', value: 'username' },
// { label: 'Student Email', value: 'email' },
{ label: 'Student Email', value: 'email' },
{ label: 'Grade', value: 'grade' },
{ label: 'Password', value: 'password' },
{ label: 'Student Date of Birth', value: 'dob' },
Expand Down
3 changes: 3 additions & 0 deletions src/pages/ScoreReport.vue
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,7 @@ const exportSelected = (selectedRows) => {
const computedExportData = _map(selectedRows, ({ user, assignment }) => {
let tableRow = {
Username: _get(user, 'username'),
Email: _get(user, 'email'),
First: _get(user, 'name.first'),
Last: _get(user, 'name.last'),
Grade: _get(user, 'studentData.grade'),
Expand Down Expand Up @@ -850,6 +851,7 @@ const exportAll = async () => {
const computedExportData = _map(exportData, ({ user, assignment }) => {
let tableRow = {
Username: _get(user, 'username'),
Email: _get(user, 'email'),
First: _get(user, 'name.first'),
Last: _get(user, 'name.last'),
Grade: _get(user, 'studentData.grade'),
Expand Down Expand Up @@ -921,6 +923,7 @@ const columns = computed(() => {
if (scoresDataQuery.value === undefined) return [];
const tableColumns = [
{ field: 'user.username', header: 'Username', dataType: 'text', pinned: true, sort: true },
{ field: 'user.email', header: 'Email', dataType: 'text', pinned: false, sort: true },
{ field: 'user.name.first', header: 'First Name', dataType: 'text', sort: true },
{ field: 'user.name.last', header: 'Last Name', dataType: 'text', sort: true },
{ field: 'user.studentData.grade', header: 'Grade', dataType: 'text', sort: true, filter: false },
Expand Down

0 comments on commit 44c894e

Please sign in to comment.