Merge pull request #793 from yeatmanlab/enh/for-each-fallback

Add fallback values before calling the forEach method
yeatmanlab · Sep 12, 2024 · 71bc630 · 71bc630
2 parents dd9a07f + 337e348
commit 71bc630
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -32,7 +32,7 @@
   },
   "dependencies": {
     "@bdelab/roam-fluency": "1.11.26",
-    "@bdelab/roar-firekit": "^8.0.7",
+    "@bdelab/roar-firekit": "^8.0.8",
     "@bdelab/roar-letter": "1.11.5",
     "@bdelab/roar-multichoice": "^1.11.3",
     "@bdelab/roar-pa": "2.2.4",

diff --git a/src/components/CardAdministration.vue b/src/components/CardAdministration.vue
@@ -396,7 +396,7 @@ const fetchTreeOrgs = async () => {
   treeTableOrgs.push(...dsgfOrgs.filter((node) => node.data.orgType === 'group'));
   treeTableOrgs.push(...dsgfOrgs.filter((node) => node.data.orgType === 'family'));
 
-  treeTableOrgs.forEach((node) => {
+  (treeTableOrgs ?? []).forEach((node) => {
     // Sort the schools by existance of stats then alphabetically
     if (node.children) {
       node.children.sort((a, b) => {
@@ -499,8 +499,8 @@ const onExpand = async (node) => {
     });
 
     // Sort the classes by existance of stats then alphabetically
-    newNodes.forEach((districtNode) => {
-      districtNode.children.forEach((schoolNode) => {
+    (newNodes ?? []).forEach((districtNode) => {
+      (districtNode?.children ?? []).forEach((schoolNode) => {
         if (schoolNode.children) {
           schoolNode.children.sort((a, b) => {
             if (!a.data.stats) return 1;