-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cypress Test Concurrency #570
Conversation
Visit the preview URL for this PR (updated for commit e625fb9): https://roar-staging--pr570-fix-test-concurrency-ilzgpeaf.web.app (expires Thu, 23 May 2024 16:40:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
Passing run #1784 ↗︎
Details:
Review all test suite changes for PR #570 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Light changes requested. Also, I'm not sure I caught every instance of 60 * timeout
so I'd advise looking for that as well.
Thanks! This looks great!
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification that this is just to trigger/test the tests. Please change back when appropriate.
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification that this is just to trigger/test the tests. Please revert when appropriate
8827ba9
to
e4e0282
Compare
…compare to feature branch package json
… for test workflows.
e4e0282
to
e625fb9
Compare
This PR attempts to fix an issue with Cypress tests concurrently modifying the same document, resulting in failed tests. It introduces a check to see if the app/game npm package has changed within a new PR; if so, it runs the tests for that game. This PR also splits the Cypress test suite into multiple GitHub workflows: participant, partner, super admin.