Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Tasks and Variants #597

Merged
merged 36 commits into from
Jul 9, 2024
Merged

Manage Tasks and Variants #597

merged 36 commits into from
Jul 9, 2024

Conversation

ksmontville
Copy link
Collaborator

@ksmontville ksmontville commented May 21, 2024

This PR builds out the initial components for managing tasks and variants through the Dashboard. Requires an updated version of Firekit which enables these methods.

Will need to retroactively add gameConfig to each current task document.

Companion Firekit PRs: yeatmanlab/roar-firekit#111, yeatmanlab/roar-firekit#116

Also makes small changes to Vue router and navbar.

Copy link

github-actions bot commented May 21, 2024

Visit the preview URL for this PR (updated for commit 6881234):

https://roar-staging--pr597-manage-tasks-variant-810ixq0q.web.app

(expires Tue, 16 Jul 2024 18:26:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented May 21, 2024

Passing run #3900 ↗︎

0 26 0 0 Flakiness 0

Details:

Tests for PR 597 "Manage Tasks and Variants" from commit "688123424646f5412d7856...
Project: roar-dashboard-e2e Commit: 6881234246
Status: Passed Duration: 03:30 💡
Started: Jul 9, 2024 6:26 PM Ended: Jul 9, 2024 6:30 PM

Review all test suite changes for PR #597 ↗︎

@ksmontville
Copy link
Collaborator Author

image
image
image

@ksmontville ksmontville marked this pull request as ready for review May 23, 2024 22:41
@ksmontville ksmontville changed the title wip/Manage Tasks and Variants Manage Tasks and Variants May 23, 2024
@ksmontville ksmontville force-pushed the manage-tasks-variants branch 5 times, most recently from f98cc39 to 87cc39f Compare June 3, 2024 16:38
Copy link
Contributor

@Emily-ejag Emily-ejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but maybe adding a handler in the dropdown on selected variants, because it is showing empty variants:
image

@Emily-ejag
Copy link
Contributor

Emily-ejag commented Jun 3, 2024

Also If I add a new Param and called the same thing as an existing, it overwrites the value, for example I changed "consent" by adding a new param, and switch from boolean to string, I suggest a error handling here if the params have the same name, to not overwrite:
image

Copy link
Collaborator

@lucasxsong lucasxsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good and will be a great feature add to the dashboard! I had a few comments, let me know if you'd like to talk about anything.

src/components/tasks/ManageTasks.vue Outdated Show resolved Hide resolved
src/components/tasks/ManageVariants.vue Outdated Show resolved Hide resolved
src/components/tasks/ManageTasks.vue Outdated Show resolved Hide resolved
src/components/tasks/ManageVariants.vue Outdated Show resolved Hide resolved
src/components/tasks/ManageVariants.vue Outdated Show resolved Hide resolved
src/components/tasks/ManageTasks.vue Outdated Show resolved Hide resolved
src/components/tasks/ManageTasks.vue Outdated Show resolved Hide resolved
src/components/tasks/ManageVariants.vue Outdated Show resolved Hide resolved
src/components/tasks/ManageVariants.vue Outdated Show resolved Hide resolved
src/router/index.js Show resolved Hide resolved
@ksmontville
Copy link
Collaborator Author

Also If I add a new Param and called the same thing as an existing, it overwrites the value, for example I changed "consent" by adding a new param, and switch from boolean to string, I suggest a error handling here if the params have the same name, to not overwrite: image

This is a great catch, thank you.

I have added some validation that should address this.

@ksmontville ksmontville merged commit 3bfe6ef into main Jul 9, 2024
16 checks passed
@ksmontville ksmontville deleted the manage-tasks-variants branch July 9, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants