Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream sync 1 #682

Open
wants to merge 128 commits into
base: main
Choose a base branch
from
Open

Upstream sync 1 #682

wants to merge 128 commits into from

Conversation

Zio-4
Copy link
Contributor

@Zio-4 Zio-4 commented Jun 21, 2024

Proposed changes

This is the first upstream sync from the LEVANTE fork. The following changes are included

  • Core tasks bumped to version 16. Includes state refactor to be in memory and styling changes for H&F.
  • Fix for the dob check which was throwing warnings
  • Fixing a typo for the LEVANTE survey "task", survey now saves data regardless if the user responded
  • Clearing the game store state on sign out. This was causing an issue when subsequent children were using the same device and seeing the survey as complete from a previous users response.
  • German translations for sign page + child view.
  • Hiding the SSO logins for admin users (LEVANTE only). We received feedback from our Germany partners that parents / children may get confused and try to use that to sign in. There is a now prompt clearly stating these logins are for admins only.

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

Zio-4 and others added 21 commits June 4, 2024 22:36
saving all responses for survey, fixing survey data fetching
Fix - Subsequent children seeing survey marked as complete.
Adding German translations for sign in +child view
src/pages/SignIn.vue Outdated Show resolved Hide resolved
@Zio-4 Zio-4 requested a review from a team as a code owner September 17, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants