-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primevue Update #720
Primevue Update #720
Conversation
Visit the preview URL for this PR (updated for commit 59679ba): https://roar-staging--pr720-enh-primeview-update-b6ljxffb.web.app (expires Fri, 23 Aug 2024 19:34:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
…nto enh/primeview-update
…nto enh/primeview-update
…nto enh/primeview-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the full PR yet, but just a thought on the light/dark mode issue @Emily-ejag
…nto enh/primeview-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Emily-ejag, this looks great! However, I noticed that the family sign-up route was still messed up. Can you take a look at the /register
form?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, sorry, I retract my previous approval. I don't see the tabs at the bottom of the group score report. Can you restore them?
…nto enh/primeview-update
Oh I see, thanks @Emily-ejag. Sorry, I misunderstood. You already had a fix for that merged. Thanks for explicitly showing that to me. |
Proposed changes
Types of changes
What types of changes does this pull request introduce?
Checklist
Justification of missing checklist items
Further comments