Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primevue Update #720

Merged
merged 36 commits into from
Aug 16, 2024
Merged

Primevue Update #720

merged 36 commits into from
Aug 16, 2024

Conversation

Emily-ejag
Copy link
Contributor

@Emily-ejag Emily-ejag commented Jul 23, 2024

  • updating primevue primeflex and primeicons
  • adding new components and update others

Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

Copy link

github-actions bot commented Jul 23, 2024

Visit the preview URL for this PR (updated for commit 59679ba):

https://roar-staging--pr720-enh-primeview-update-b6ljxffb.web.app

(expires Fri, 23 Aug 2024 19:34:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Jul 23, 2024



Test summary

26 0 0 0Flakiness 0


Run details

Project roar-dashboard-e2e
Status Passed
Commit 59679ba
Started Aug 16, 2024 7:33 PM
Ended Aug 16, 2024 7:37 PM
Duration 04:32 💡
OS Linux Ubuntu -
Browser Edge 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@Emily-ejag Emily-ejag changed the title WIP: Primevue Update Primevue Update Jul 29, 2024
@Zio-4
Copy link
Contributor

Zio-4 commented Aug 1, 2024

Is this WIP?

Everything is dark and the sign in page input stretched outside of it's container
Screenshot 2024-08-01 at 1 37 45 PM
Screenshot 2024-08-01 at 1 38 24 PM

Copy link
Collaborator

@maximilianoertel maximilianoertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the full PR yet, but just a thought on the light/dark mode issue @Emily-ejag

src/main.js Outdated Show resolved Hide resolved
Copy link
Contributor

@richford richford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Emily-ejag, this looks great! However, I noticed that the family sign-up route was still messed up. Can you take a look at the /register form?

Screenshot 2024-08-15 at 3 04 59 PM

@richford
Copy link
Contributor

Additionally, the menu collapse isn't behaving as before. When I change the width of the browser, I get the following:
Screenshot 2024-08-15 at 3 10 17 PM
and
Screenshot 2024-08-15 at 3 07 35 PM

Copy link
Contributor

@richford richford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, sorry, I retract my previous approval. I don't see the tabs at the bottom of the group score report. Can you restore them?

@richford
Copy link
Contributor

Oh I see, thanks @Emily-ejag. Sorry, I misunderstood. You already had a fix for that merged. Thanks for explicitly showing that to me.

@Emily-ejag Emily-ejag merged commit a39ff4c into main Aug 16, 2024
18 checks passed
@Emily-ejag Emily-ejag deleted the enh/primeview-update branch August 16, 2024 19:38
@Emily-ejag Emily-ejag restored the enh/primeview-update branch August 20, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants