Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add password to createAdministrator form #746

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kellyel
Copy link
Collaborator

@kellyel kellyel commented Aug 15, 2024

Proposed changes

This PR adds an optional password field to the createAdministrator form

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.96% 73 / 7551
🔵 Statements 0.92% 74 / 8041
🔵 Functions 0.69% 14 / 2007
🔵 Branches 0.47% 20 / 4216
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/CreateAdministrator.vue 0% 0% 0% 0% 103-106, 108-113, 115-116, 119-122, 120, 120-121, 124-126, 125, 125, 128-130, 129, 129, 132, 134-136, 135, 138-195, 139-148, 141-147, 150, 152-156, 158-164, 159-163, 168-171, 170, 173-176, 174-175, 178-194, 188-189, 192-193, 2-4, 16-18, 25, 28-29, 36, 39-40, 42, 46-48, 50, 53-54, 56, 62-63, 71, 21, 32, 41, 49, 55, 61, 64
Generated in workflow #11

Copy link

github-actions bot commented Aug 15, 2024

Visit the preview URL for this PR (updated for commit a345cf6):

https://roar-staging--pr746-enh-new-admin-passwo-c7bt35r7.web.app

(expires Thu, 22 Aug 2024 21:08:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Aug 15, 2024



Test summary

26 0 0 0Flakiness 0


Run details

Project roar-dashboard-e2e
Status Passed
Commit a345cf6
Started Aug 15, 2024 9:09 PM
Ended Aug 15, 2024 9:13 PM
Duration 04:19 💡
OS Linux Ubuntu -
Browser Edge 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant