Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Offline/PWA code #829

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Remove Offline/PWA code #829

merged 2 commits into from
Sep 24, 2024

Conversation

lucasxsong
Copy link
Collaborator

Proposed changes

Removing changes that were added during the attempted conversion of the dashboard to be an offline pwa. Since we are going a different route now, these changes are no longer needed.

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@lucasxsong lucasxsong requested a review from a team as a code owner September 24, 2024 18:20
Copy link

github-actions bot commented Sep 24, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.97% 73 / 7476
🔵 Statements 0.9% 74 / 8211
🔵 Functions 0.76% 14 / 1819
🔵 Branches 0.44% 20 / 4496
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/router/index.js 0% 0% 0% 0% 7, 7, 11, 11, 14-417, 18, 31, 37, 43, 50, 57, 64, 71, 78, 85, 92, 99, 106, 113, 120, 127, 134, 141, 148, 155, 162, 169, 176, 185, 192, 199, 207, 213-214, 219, 224, 232, 238, 253-256, 255, 258-260, 275-276, 283-284, 291, 297, 303, 309, 316, 322, 328, 334, 341, 348, 355, 362, 368, 370, 374, 380, 389, 395, 402, 408, 414, 419-428, 423-424, 424-425, 425-426, 430-510, 431, 433-437, 434, 436, 439, 441-449, 451, 453-459, 454-459, 457-458, 461-468, 466-467, 471-472, 475-476, 484-500, 485-500, 491-497, 492-497, 495-496, 498-499, 503-506, 504-505, 508-509
Generated in workflow #447

Copy link

github-actions bot commented Sep 24, 2024

Visit the preview URL for this PR (updated for commit b916785):

https://roar-staging--pr829-fix-remove-offline-c-0b3603wr.web.app

(expires Tue, 01 Oct 2024 18:27:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Sep 24, 2024

roar-dashboard-e2e    Run #7188

Run Properties:  status check passed Passed #7188  •  git commit b916785c24: Component Tests for PR 829 "Remove Offline/PWA code" from commit "b916785c242b93...
Project roar-dashboard-e2e
Branch Review fix/remove-offline-code
Run status status check passed Passed #7188
Run duration 01m 32s
Commit git commit b916785c24: Component Tests for PR 829 "Remove Offline/PWA code" from commit "b916785c242b93...
Committer Lucas Song
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
View all changes introduced in this branch ↗︎

@richford richford merged commit c1de6b0 into main Sep 24, 2024
23 of 24 checks passed
@richford richford deleted the fix/remove-offline-code branch September 24, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants