-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Students should not be able to see their demographic data #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 8421a93): https://roar-staging--pr831-fix-do-not-show-demo-e00r1cda.web.app (expires Mon, 07 Oct 2024 20:11:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
Coverage Report
File Coverage
|
roar-dashboard-e2e Run #7514
Run Properties:
|
Project |
roar-dashboard-e2e
|
Branch Review |
fix/do-not-show-demographics-to-students
|
Run status |
Passed #7514
|
Run duration | 01m 24s |
Commit |
8421a93882: Component Tests for PR 831 "Fix - Students should not be able to see their demog...
|
Committer | Emily Arteaga |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
2
|
View all changes introduced in this branch ↗︎ |
kellyel
approved these changes
Sep 26, 2024
maximilianoertel
approved these changes
Sep 27, 2024
richford
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding v-if to only show if the user is admin or super admin
Types of changes
What types of changes does this pull request introduce?
Checklist
Justification of missing checklist items
Further comments