Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Students should not be able to see their demographic data #831

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

Emily-ejag
Copy link
Contributor

@Emily-ejag Emily-ejag commented Sep 25, 2024

Proposed changes

Adding v-if to only show if the user is admin or super admin

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@Emily-ejag Emily-ejag requested a review from a team as a code owner September 25, 2024 18:51
Copy link

github-actions bot commented Sep 25, 2024

Visit the preview URL for this PR (updated for commit 8421a93):

https://roar-staging--pr831-fix-do-not-show-demo-e00r1cda.web.app

(expires Mon, 07 Oct 2024 20:11:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

@Emily-ejag Emily-ejag self-assigned this Sep 25, 2024
@Emily-ejag Emily-ejag added the bug Something isn't working label Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.97% 73 / 7475
🔵 Statements 0.9% 74 / 8210
🔵 Functions 0.76% 14 / 1819
🔵 Branches 0.44% 20 / 4497
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/NavBar.vue 0% 0% 0% 0% 82-88, 91-94, 92, 92-93, 96-98, 97, 97, 100-102, 101, 104-107, 105, 105-106, 109-111, 110, 115-121, 117, 123-125, 124, 127-150, 128-148, 131-141, 132, 134-140, 138, 142-147, 143-146, 149, 152-169, 153-168, 154, 156-159, 158, 160-167, 164, 166, 171-175, 172, 172-173, 173-174, 177, 177, 179-181, 180, 183-189, 184-188, 191-206, 196, 203, 208-234, 209-233, 216, 223, 230, 236-238, 237, 3, 5, 9, 24, 1, 56
Generated in workflow #514 for commit 8421a93 by the Vitest Coverage Report Action

Copy link

cypress bot commented Sep 25, 2024

roar-dashboard-e2e    Run #7514

Run Properties:  status check passed Passed #7514  •  git commit 8421a93882: Component Tests for PR 831 "Fix - Students should not be able to see their demog...
Project roar-dashboard-e2e
Branch Review fix/do-not-show-demographics-to-students
Run status status check passed Passed #7514
Run duration 01m 24s
Commit git commit 8421a93882: Component Tests for PR 831 "Fix - Students should not be able to see their demog...
Committer Emily Arteaga
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
View all changes introduced in this branch ↗︎

@richford richford merged commit b3c91af into main Sep 30, 2024
23 of 24 checks passed
@richford richford deleted the fix/do-not-show-demographics-to-students branch September 30, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants