Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Students should not be able to see their demographic data #831

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Fix - Students should not be able to see their demographic data #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf03731
adding v-if
Emily-ejag Sep 25, 2024
3f4a3a0
the button-profile-info no longer for students
Emily-ejag Sep 25, 2024
8421a93
Merge branch 'main' into fix/do-not-show-demographics-to-students
Emily-ejag Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/component/components/NavBar.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe('<NavBar />', () => {
// Check that the component is mounted and the expected elements are present
cy.get('nav').should('exist');
cy.get('[data-cy=button-sign-out]').should('exist');
cy.get('[data-cy=button-profile-info]').should('exist');
// @NOTE the students not longer have button-profile-info
});

it('mounts using a desktop viewport', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/NavBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
>
</router-link>
</div>
<div class="nav-user-wrapper bg-gray-100">
<div v-if="authStore.isUserAdmin" class="nav-user-wrapper bg-gray-100">
<router-link :to="{ name: 'ProfileInfo' }"
><button
data-cy="button-profile-info"
Expand Down