Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app launching behavior #850

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Update app launching behavior #850

merged 1 commit into from
Oct 4, 2024

Conversation

kellyel
Copy link
Collaborator

@kellyel kellyel commented Oct 4, 2024

Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@kellyel kellyel requested a review from a team as a code owner October 4, 2024 19:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.98% 73 / 7426
🔵 Statements 0.9% 74 / 8159
🔵 Functions 0.77% 14 / 1806
🔵 Branches 0.44% 20 / 4453
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/tasks/TaskCrowding.vue 0% 0% 0% 0% 19, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-74, 67-71, 68, 70, 73, 73, 76-78, 77, 80-86, 83, 83, 88, 91-130, 92-99, 94-98, 96-97, 101, 103-104, 106-111, 113, 115, 117-124, 119, 122-123, 126-129, 2
src/components/tasks/TaskFluency.vue 0% 0% 0% 0% 19, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-74, 67-71, 68, 70, 73, 73, 76-78, 77, 80-86, 83, 83, 88, 91-130, 92-99, 94-98, 96-97, 101, 103-104, 106-111, 113, 115, 117-124, 119, 122-123, 126-129
src/components/tasks/TaskLetter.vue 0% 0% 0% 0% 19, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-74, 67-71, 68, 70, 73, 73, 76-78, 77, 80-86, 83, 83, 88, 91-130, 92-99, 94-98, 96-97, 101, 103-104, 106-111, 113, 115, 117-124, 119, 122-123, 126-129
src/components/tasks/TaskLevante.vue 0% 0% 0% 0% 20, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-75, 67-72, 68-69, 71, 74, 74, 77-79, 78, 81-87, 84, 84, 89, 92-130, 93-100, 95-99, 97-98, 102, 104-105, 107-111, 113, 115, 117-124, 119, 122-123, 126-129
src/components/tasks/TaskMEP.vue 0% 0% 0% 0% 19, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-74, 67-71, 68, 70, 73, 73, 76-78, 77, 80-86, 83, 83, 88, 91-130, 92-99, 94-98, 96-97, 101, 103-104, 106-111, 113, 115, 117-124, 119, 122-123, 126-129, 2
src/components/tasks/TaskMultichoice.vue 0% 0% 0% 0% 19, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-74, 67-71, 68, 70, 73, 73, 76-78, 77, 80-86, 83, 83, 88, 91-130, 92-99, 94-98, 96-97, 101, 103-104, 106-111, 113, 115, 117-124, 119, 122-123, 126-129
src/components/tasks/TaskPA.vue 0% 0% 0% 0% 19, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-74, 67-71, 68, 70, 73, 73, 76-78, 77, 80-86, 83, 83, 88, 91-130, 92-99, 94-98, 96-97, 101, 103-104, 106-111, 113, 115, 117-124, 119, 122-123, 126-129
src/components/tasks/TaskRan.vue 0% 0% 0% 0% 19, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-74, 67-71, 68, 70, 73, 73, 76-78, 77, 80-86, 83, 83, 88, 91-130, 92-99, 94-98, 96-97, 101, 103-104, 106-111, 113, 115, 117-124, 119, 122-123, 126-129, 2
src/components/tasks/TaskSRE.vue 0% 0% 0% 0% 19, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-74, 67-71, 68, 70, 73, 73, 76-78, 77, 80-86, 83, 83, 88, 91-130, 92-99, 94-98, 96-97, 101, 103-104, 106-111, 113, 115, 117-124, 119, 122-123, 126-129
src/components/tasks/TaskSWR.vue 0% 0% 0% 0% 19, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-74, 67-71, 68, 70, 73, 73, 76-78, 77, 80-86, 83, 83, 88, 91-130, 92-99, 94-98, 96-97, 101, 103-104, 106-111, 113, 115, 117-124, 119, 122-123, 126-129
src/components/tasks/TaskVocab.vue 0% 0% 0% 0% 19, 26-32, 34, 36-39, 37, 37-38, 40-42, 41, 44-46, 45, 45, 48-54, 50, 58-64, 61, 66-74, 67-71, 68, 70, 73, 73, 76-78, 77, 80-86, 83, 83, 88, 91-130, 92-99, 94-98, 96-97, 101, 103-104, 106-111, 113, 115, 117-124, 119, 122-123, 126-129
Generated in workflow #573 for commit b9bb37c by the Vitest Coverage Report Action

@Emily-ejag Emily-ejag added the bug Something isn't working label Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited by unfurl-links bot
Loading

Visit the preview URL for this PR (updated for commit b9bb37c):

https://roar-staging--pr850-fix-task-launcher-fflpa3yu.web.app

(expires Fri, 11 Oct 2024 19:37:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

@cypress Cypress
Copy link

cypress bot commented Oct 4, 2024 •
edited
Loading

roar-dashboard-e2e    Run #7843

Run Properties:  status check passed Passed #7843  •  git commit b9bb37c80d: E2E Tests for PR 850 "Update app launching behavior" from commit "b9bb37c80d6d23...
Project roar-dashboard-e2e
Branch Review fix/task-launcher
Run status status check passed Passed #7843
Run duration 03m 49s
Commit git commit b9bb37c80d: E2E Tests for PR 850 "Update app launching behavior" from commit "b9bb37c80d6d23...
Committer Elijah Kelly
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 13
View all changes introduced in this branch ↗︎

@richford richford merged commit 47c6ac0 into main Oct 4, 2024
24 checks passed
@richford richford deleted the fix/task-launcher branch October 4, 2024 19:47
@sentry-io Sentry.io
Copy link

sentry-io bot commented Oct 7, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ReferenceError: Cannot access 'y' before initialization startTask(src/components/tasks/TaskLevante) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richford richford richford approved these changes

@Emily-ejag Emily-ejag Emily-ejag approved these changes

Assignees

@kellyel kellyel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyel @richford @Emily-ejag