Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress pandas FutureWarnings #165

Merged
merged 12 commits into from
Dec 2, 2024

Conversation

JPhillips92
Copy link
Contributor

@JPhillips92 JPhillips92 commented Nov 16, 2023

Fixes #156.

@yehoshuadimarsky
Copy link
Owner

Thanks, but the better solution would be to just replace applymap with map, do you want to do that instead?

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.22%. Comparing base (7b471db) to head (a05c166).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files           4        4           
  Lines         277      277           
=======================================
  Hits          261      261           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yehoshuadimarsky
Copy link
Owner

looks great thanks. but why are you also changing the minimum python version from 3.8 to 3.9?

@JPhillips92
Copy link
Contributor Author

JPhillips92 commented Nov 22, 2023

Sorry I meant to add a comment about that yesterday. I had to bump python because pandas.DataFrame.map is new for pandas v2.1 ref and it requires python 3.9 or higher ref.

@yehoshuadimarsky
Copy link
Owner

Sorry but Python 3.8 is still not end-of-life, I don't think we can drop support for it by requiring Python 3.9+

@JPhillips92
Copy link
Contributor Author

@yehoshuadimarsky That's fair enough. Since we can't use map yet, do you want me to roll this back to the initial 'Suppress pandas FutureWarning' fix or just close it?

@taslater
Copy link

taslater commented Apr 3, 2024

@JPhillips92

@yehoshuadimarsky That's fair enough. Since we can't use map yet, do you want me to roll this back to the initial 'Suppress pandas FutureWarning' fix or just close it?

I'm sorry, why can't map be used instead of applymap?

@gordthompson
Copy link
Contributor

3.8 went EOL two weeks ago.

@yehoshuadimarsky
Copy link
Owner

Sorry this took so long, it took me a while to get all the versions of pandas numpy and python to work with each other, finally dropped support for python 3.8 and added 3.12+ here #218.

I hope this unblocks you, feel free to update your PR now. Note, I recently changed the build system to use uv from poetry.

@yehoshuadimarsky yehoshuadimarsky merged commit 78ddcd6 into yehoshuadimarsky:master Dec 2, 2024
11 checks passed
@yehoshuadimarsky
Copy link
Owner

Thanks! Appreciate the patience as well

@yehoshuadimarsky
Copy link
Owner

Blocked from publishing this to PyPI until I resolve this issue, apologies: #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FutureWarning: DataFrame Applymap Depricated.
4 participants