Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump meow to 9.0 to reduce vulnerable dependencies #817

Closed
wants to merge 2 commits into from

Conversation

gyz0072004
Copy link

@gyz0072004 gyz0072004 commented Oct 22, 2024

Purpose of this pull request?

  • Documentation update
  • Bug fix
  • Enhancement
  • Other, please explain:

What changes did you make?

Bump the version of meow to the latest non-ESM version to resolve npm audit issues.

Is there anything you'd like reviewers to focus on?

Would like a published version if the change is OK.

@gyz0072004 gyz0072004 closed this Oct 22, 2024
@gyz0072004 gyz0072004 reopened this Oct 22, 2024
@gyz0072004
Copy link
Author

@mshima Could you please take a look on this? Thanks.

@gyz0072004
Copy link
Author

@mshima Kindly ping. Could you please take a look? Thanks.

@mshima
Copy link
Member

mshima commented Oct 29, 2024

Sorry for the delay.
I am worried about https://github.com/sindresorhus/meow/releases/tag/v9.0.0 breaking changes.
The kebab parameter change.
I wonder if this will break legacy generators.

@gyz0072004
Copy link
Author

I got your concern. Then do we have any plan to migrate yo to pure ESM package as a major release? I think some yeoman has done the migration.

@gyz0072004
Copy link
Author

I'm closing the PR for now.

@gyz0072004 gyz0072004 closed this Oct 31, 2024
@mshima
Copy link
Member

mshima commented Oct 31, 2024

I got your concern. Then do we have any plan to migrate yo to pure ESM package as a major release? I think some yeoman has done the migration.

Last yo major version had legacy generator issues, so I am very careful about yo changes to avoid angry reactions.
yo and yeoman-enviroment have quite unique use case. The must have almost 0 breaking changes forever to don't break old generators. They are engines instead of dependencies.

We use a custom cli in JHipster and yeoman-environment has a cli itself (yoe).
So I would say that another cli (@yeoman/cli) based on yeoman-environment cli support is the easiest way to move forward but as I've said we use custom cli, so I will not lead the task myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants