fix: remove pointer on docs and extra impl in main.rs

yetanotherco · Sep 24, 2024 · 25d8cff · 25d8cff
1 parent 44b3988
commit 25d8cff
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 16 deletions.
diff --git a/batcher/aligned/src/main.rs b/batcher/aligned/src/main.rs
@@ -217,16 +217,6 @@ impl From<NetworkArg> for Network {
     }
 }
 
-impl From<&NetworkArg> for Network {
-    fn from(env_arg: &NetworkArg) -> Self {
-        match env_arg {
-            NetworkArg::Devnet => Network::Devnet,
-            NetworkArg::Holesky => Network::Holesky,
-            NetworkArg::HoleskyStage => Network::HoleskyStage,
-        }
-    }
-}
-
 #[derive(Debug, Clone, ValueEnum)]
 pub enum ProvingSystemArg {
     #[clap(name = "GnarkPlonkBls12_381")]

diff --git a/docs/3_guides/1.2_SDK_api_reference.md b/docs/3_guides/1.2_SDK_api_reference.md
@@ -9,7 +9,7 @@ Submits a proof to the batcher to be verified and returns an aligned verificatio
 ```rust
 pub async fn submit(
     batcher_url: &str,
-    network: &Network,
+    network: Network,
     verification_data: &VerificationData,
     max_fee; U256,
     wallet: Wallet<SigningKey>,
@@ -55,7 +55,7 @@ Submits multiple proofs to the batcher to be verified and returns an aligned ver
 ```rust
 pub async fn submit_multiple(
     batcher_url: &str,
-    network: &Network,
+    network: Network,
     verification_data: &[VerificationData],
     max_fees: &[U256],
     wallet: Wallet<SigningKey>,
@@ -104,7 +104,7 @@ verification data struct.
 pub async fn submit_and_wait_verification(
     batcher_url: &str,
     eth_rpc_url: &str,
-    network: &Network,
+    network: Network,
     verification_data: &VerificationData,
     max_fee: U256,
     wallet: Wallet<SigningKey>,
@@ -158,7 +158,7 @@ verification data array.
 pub async fn submit_multiple_and_wait_verification(
     batcher_url: &str,
     eth_rpc_url: &str,
-    network: &Network,
+    network: Network,
     verification_data: &[VerificationData],
     wallet: Wallet<SigningKey>,
     nonce: U256,
@@ -210,7 +210,7 @@ Checks if the proof has been verified with Aligned and is included in the batch
 ```rust
 pub async fn is_proof_verified(
     aligned_verification_data: AlignedVerificationData,
-    network: &Network,
+    network: Network,
     eth_rpc_url: &str,
     payment_service_addr: &str,
 ) -> Result<bool, errors::VerificationError>
@@ -260,7 +260,7 @@ Returns the nonce to use for a given address.
 pub async fn get_next_nonce(
     eth_rpc_url: &str,
     submitter_addr: Address,
-    network: &Network,
+    network: Network,
 ) -> Result<U256, errors::NonceError>
 ```