fix(code quality): Remove panics from functions that return result #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
reviewed
Sep 23, 2024
batcher/aligned-batcher/src/main.rs
Outdated
| @@ -46,7 +46,7 @@ async fn main() -> Result<(), BatcherError> { | |||
| // spawn task to listening for incoming blocks | |||
| tokio::spawn({ | |||
| let app = batcher.clone(); | |||
| async move { app.listen_new_blocks().await.unwrap() } | |||
| async move { app.listen_new_blocks().await } | |||
There was a problem hiding this comment.
This seems to ignore the errors, is that correct?
There was a problem hiding this comment.
This change seems strange, the unwrap should stay, app can't recover from this
There was a problem hiding this comment.
We can change it to an expect to make it more clear that we cannot recover from this
Oppen
reviewed
Sep 23, 2024
| "Failed to create wallet from anvil private key: {}", | ||
| e.to_string() | ||
| ); | ||
| return Ok(()); |
There was a problem hiding this comment.
Should the error be forwarded?
There was a problem hiding this comment.
This is already the return of the main function. Not much to do, but we could create an issue to return an Error everywhere so the application ends with an Error
MauroToscano
approved these changes
Sep 24, 2024
uri-99
approved these changes
Sep 24, 2024
entropidelic
deleted the
951-remove-panics-from-functions-that-return-result
branch
This was referenced Sep 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #951
Removes possible panics in
aligned_batcherandaligned::main.