refactor: remove 0 check in recovered address in BatcherPaymentService #1064
+9
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes the check for zero addresses in the recovered signature within the
BatcherPaymentService
contract. The library handling the signature recovery already performs this check when splitting the fields (r
,v
,s
) first and then calling theecrecover
precompile, where it does the check (see here).Testing
I've tested that everything works by setting up a local environment and sending some
sp1
andplonk
proofs. Here is the process:make aggregator_start
.make operator_register_and_start
.make batcher_start_local
.Contracts have been updated with
make anvil_deploy_aligned_contracts
.Closes #1061