chore(security): Bump gnark version #991
Merged
+886
−828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entropidelic
requested changes
Sep 17, 2024
There was a problem hiding this comment.
when testing, Go projects don't build. It seems there has been some API changes
make aggregator_start
Starting Aggregator...
# github.com/crate-crypto/go-kzg-4844/internal/kzg
../go/pkg/mod/github.com/crate-crypto/go-kzg-4844@v1.0.0/internal/kzg/kzg_verify.go:73:20: claimedValueG1Jac.ScalarMultiplicationAffine undefined (type bls12381.G1Jac has no field or method ScalarMultiplicationAffine)%
PatStiles
force-pushed
the
chore/bump_gnark_version
branch
from
8a154f7
to
7930e82
Compare
|
|
…hore/bump_gnark_version
|
@entropidelic re-importing the gnark packages in the batcher resolved the verification error on my end. |
…hore/bump_gnark_version
|
after running |
entropidelic
approved these changes
Sep 23, 2024
|
We should specify the new supported gnark version on the docs |
|
@MauroToscano Docs updated |
uri-99
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the gnark version from v.0.11.0 -> v.0.14.0 to address security concerns outlined by the gnark team here. Closes #967