Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support async sessions #709

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

callamd
Copy link
Contributor

@callamd callamd commented Dec 6, 2024

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
authx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:02pm

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.62%. Comparing base (d28e4e1) to head (41f378a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
authx/_internal/_memory.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   98.74%   98.62%   -0.13%     
==========================================
  Files          16       16              
  Lines         796      799       +3     
  Branches       78       79       +1     
==========================================
+ Hits          786      788       +2     
  Misses          4        4              
- Partials        6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

sonarqubecloud bot commented Dec 6, 2024

@yezz123 yezz123 linked an issue Dec 6, 2024 that may be closed by this pull request
@yezz123 yezz123 added the feature label Dec 6, 2024
@yezz123 yezz123 changed the title Support async sessions #708 ✨ Support async sessions Dec 6, 2024
@yezz123 yezz123 merged commit 5113868 into yezz123:main Dec 6, 2024
47 of 49 checks passed
@yezz123
Copy link
Owner

yezz123 commented Dec 6, 2024

@all-contributors please add @callamd for code

Copy link
Contributor

@yezz123

I've put up a pull request to add @callamd! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session data providers should be async
2 participants