fix

yiisoft · Mar 14, 2024 · 17c985a · 17c985a
1 parent 1ca74ca
commit 17c985a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/src/NotFoundException.php b/src/NotFoundException.php
@@ -24,12 +24,12 @@ public function __construct(
     ) {
         if (empty($this->buildStack)) {
             $message = sprintf('No definition or class found or resolvable for "%s".', $id);
-        } elseif (count($this->buildStack) === 1) {
+        } elseif ($this->buildStack === [$id]) {
             $message = sprintf('No definition or class found or resolvable for "%s" while building it.', $id);
         } else {
             $message = sprintf(
                 'No definition or class found or resolvable for "%s" while building "%s".',
-                $id,
+                end($this->buildStack),
                 implode('" -> "', $buildStack),
             );
         }

diff --git a/tests/Unit/ContainerTest.php b/tests/Unit/ContainerTest.php
@@ -1973,12 +1973,20 @@ public function testInvalidTags(string $message, array $tags): void
         new Container($config);
     }
 
-    public function testNotFoundExceptionMessageWithDefinitions(): void
+    public static function dataNotFoundExceptionMessageWithDefinitions(): array
     {
-        $config = ContainerConfig::create()
-            ->withDefinitions([
-                SportCar::class => SportCar::class,
-            ]);
+        return [
+            'without-definition' => [[]],
+            'with-definition' => [[SportCar::class => SportCar::class]],
+        ];
+    }
+
+    /**
+     * @dataProvider dataNotFoundExceptionMessageWithDefinitions
+     */
+    public function testNotFoundExceptionMessageWithDefinitions(array $definitions): void
+    {
+        $config = ContainerConfig::create()->withDefinitions($definitions);
         $container = new Container($config);
 
         $this->expectException(NotFoundException::class);