Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut for tag reference #333 #353

Merged
merged 10 commits into from
Feb 23, 2024
Merged

Add shortcut for tag reference #333 #353

merged 10 commits into from
Feb 23, 2024

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Feb 13, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #333

Copy link

what-the-diff bot commented Feb 13, 2024

PR Summary

  • Updated References in CompositeContainer and Container Files
    These changes were made to reference the new TagReference helper class instead of the outdated TagHelper class. The core changes happened in src/CompositeContainer.php and src/Container.php files. This aids in improved functionality and better code readability.

  • Removal of Redundant TagHelper File
    The src/Helpers/TagHelper.php file was removed as it was no longer needed due to the introduction of the new TagReference class. This keeps the codebase lean and efficient.

  • Introduction of the TagReference Class
    Introduced a new helper class (TagReference) to streamline handling of references to tags. Created in the new file src/Reference/TagReference.php, this will help developers work more effectively with tags.

  • Implementation of Unit Tests for the New TagReference Class
    A new file tests/Unit/Reference/TagReferenceTest.php was added to contain unit tests for the TagReference class, ensuring that the class functions as expected and contributes to the overall stability of the system.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add line to changelog and info about TagReference to readme.

tests/Unit/Reference/TagReferenceTest.php Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c7556c1) to head (0be02f6).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #353   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       158       161    +3     
===========================================
  Files             11        11           
  Lines            460       466    +6     
===========================================
+ Hits             460       466    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xepozz xepozz changed the title Add shortcut for tag reference #333 Add shortcut for tag reference Feb 23, 2024
@xepozz xepozz changed the title Add shortcut for tag reference Add shortcut for tag reference #333 Feb 23, 2024
@xepozz xepozz requested a review from a team February 23, 2024 06:56
@xepozz xepozz added the status:code review The pull request needs review. label Feb 23, 2024
@samdark samdark merged commit aeb0856 into master Feb 23, 2024
32 checks passed
@samdark samdark deleted the tag-reference branch February 23, 2024 07:23
@samdark
Copy link
Member

samdark commented Feb 23, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants