Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package #91

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Rename package #91

merged 4 commits into from
Jan 9, 2024

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jan 4, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Related PR yiisoft/queue#184

The failed test still fail in master, I'll try to fix it separate

TODO:

  • Replace yii-queue in composer.json after renaming the yii-queue package and before merge current PR

Copy link

what-the-diff bot commented Jan 4, 2024

PR Summary

  • Name and Namespace Changes
    The package name has been changed from "Yii Queue AMQP Adapter" to "Queue AMQP Adapter". Correspondingly, multiple files had their namespaces updated and even the class DelayedMiddleware was renamed to DelayMiddleware for accuracy.

  • Files and Directory Reorganization
    To improve code readability and maintenance, several files were moved to different directories, effectively organising them better.

  • Code Improvements
    Some adjustments and updates were made in the code for better performance and readability. Also, the software's dependencies were updated, which aids in maintaining the software's compatibility with recent versions of related tools or libraries.

  • Documentation Updates
    The documentation related to the project was also updated to reflect these changes. This is crucial for the understanding of any new developer who comes onto the project.

  • Dockerfile and Test Files Update
    The Dockerfile has been updated to firstly copy composer files to /app/ before the composer install command is run, ensuring smoother operations. Additionally, various test files in the tests/Unit folder were either added or updated to make sure that newly introduced changes are working as expected.

  • use Statement Updates
    The use statements in the list of unit test files were updated to reflect the new namespace, Yiisoft\Queue\AMQP, ensuring all components and features of the package can interact properly.

Please note that all changes are done keeping in mind not only the performance of the package, but also the code's readability, clarity and maintainability.

@xepozz xepozz added the status:code review The pull request needs review. label Jan 4, 2024
@xepozz xepozz requested a review from a team January 4, 2024 16:39
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
docs/en/README.md Outdated Show resolved Hide resolved
@samdark samdark self-assigned this Jan 8, 2024
samdark and others added 3 commits January 8, 2024 12:08
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@samdark samdark merged commit e87aeae into master Jan 9, 2024
8 of 15 checks passed
@samdark samdark deleted the rename-package branch January 9, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants