Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate yii-console dep #180

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Eliminate yii-console dep #180

merged 1 commit into from
Dec 25, 2023

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Dec 25, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Dec 25, 2023

PR Summary

  • Removal of Dependency in composer.json
    The "yiisoft/yii-console" dependency has been removed. This means we no longer need this module for our code to run.

  • Constant Replacements in Commands
    Both the ListenCommand.php and RunCommand.php files have been updated to replace the ExitCode::OK instances with 0. This simplifies the exit code and avoids invoking an external library's constant.

  • Constant Replacements in Test Commands
    Similarly, the test files for both ListenCommand and RunCommand have also seen the ExitCode::OK instances replaced with 0, maintaining consistency between our main commands and our test commands.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2639357) 94.31% compared to head (b742957) 94.31%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #180   +/-   ##
=========================================
  Coverage     94.31%   94.31%           
  Complexity      340      340           
=========================================
  Files            40       40           
  Lines           915      915           
=========================================
  Hits            863      863           
  Misses           52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark merged commit eba0486 into master Dec 25, 2023
18 checks passed
@samdark samdark deleted the remove-console branch December 25, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove yiisoft/yii-console dependency & rename package to yiisoft/queue
5 participants