-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pcntl to requirements check #19780
Conversation
schmunk42
commented
Feb 27, 2023
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | #19779 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Need a line for CHANGELOG.
Hi, @schmunk42, could update the branch and add the line in CHANGELOG.md to merge it, Thks. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #19780 +/- ##
===========================================
- Coverage 48.95% 11.88% -37.07%
===========================================
Files 445 445
Lines 42811 42269 -542
===========================================
- Hits 20957 5025 -15932
- Misses 21854 37244 +15390
☔ View full report in Codecov by Sentry. |
done |
👍🏻 |