Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods to BaseYii::class. #19960

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Remove deprecated methods to BaseYii::class. #19960

merged 1 commit into from
Sep 22, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 21, 2023

PR Summary

  • Removal of method 'trace' from BaseYii.php
    The previous functionality of tracking significance in the code with 'trace' is no longer needed, leading to its removal.
  • Deletion of method 'powered' in BaseYii.php
    The 'powered' function has been deemed unnecessary in our current framework, resulting in its removal.
  • Elimination of test case for 'powered' in BaseYiiTest.php
    Corresponding to the removal of the 'powered' method, its associated test case has also been deleted from our test suite.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +41.53% 🎉

Comparison is base (b0cc791) 25.61% compared to head (1658284) 67.14%.

Additional details and impacted files
@@              Coverage Diff              @@
##                2.2   #19960       +/-   ##
=============================================
+ Coverage     25.61%   67.14%   +41.53%     
+ Complexity    11228    11226        -2     
=============================================
  Files           424      424               
  Lines         35657    35650        -7     
=============================================
+ Hits           9133    23937    +14804     
+ Misses        26524    11713    -14811     
Files Changed Coverage Δ
framework/BaseYii.php 81.66% <ø> (+18.67%) ⬆️

... and 215 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw requested a review from a team September 21, 2023 14:28
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Sep 21, 2023
@bizley bizley merged commit e7be9e9 into yiisoft:2.2 Sep 22, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants