Wildcards in yii\log\Target::$maskVars array
#20297
Conversation
xcopy
commented
Dec 10, 2024
xcopy
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues | #20295 |
| * | ||
| * @return array the flattened array. | ||
| */ | ||
| private static function flatten($array, $prefix = ''): array |
There was a problem hiding this comment.
I'm not sure this method should be here.
There was a problem hiding this comment.
Looks like a good candidate for array helper.
There was a problem hiding this comment.
Can I leave as is for now and then handle it in a separate PR? (dedicated to new ArrayHelper::flatten() method)
|
Unfortunately English is not my native language. Can anyone help with the documentation? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20297 +/- ##
=========================================
Coverage 64.83% 64.84%
- Complexity 11417 11421 +4
=========================================
Files 431 431
Lines 37155 37164 +9
=========================================
+ Hits 24090 24099 +9
Misses 13065 13065 ☔ View full report in Codecov by Sentry. |
|
Write it via Google Translate or something alike. We'll fix the language. |
| * | ||
| * @return array the flattened array. | ||
| */ | ||
| private static function flatten($array, $prefix = ''): array |
There was a problem hiding this comment.
Looks like a good candidate for array helper.
I tried my best :) |
